fix: mark the action as failed on uncaught errors #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheMrMilchmann
force-pushed
the
fix/fail-on-config-error
branch
2 times, most recently
from
3cbbb39
to
772ded0
Compare
TheMrMilchmann
added a commit
to TheMrMilchmann/setup-msvc-dev
that referenced
this pull request
Dec 31, 2023
TheMrMilchmann
added a commit
to TheMrMilchmann/setup-msvc-dev
that referenced
this pull request
Dec 31, 2023
Currently, the action does only log errors during configuration phase and for internal bugs but does not actually mark the step as failed. This change fixes this by failing the step if any error is thrown (and not caught elsewhere).
TheMrMilchmann
force-pushed
the
fix/fail-on-config-error
branch
from
772ded0
to
f3d1f41
Compare
TheMrMilchmann
changed the title
|
To add some additional context on why this is important: When Dependabot opens a PR to update this action to v4, the checks might succeed, despite |
|
Thanks for bringing this to my attention, @TheMrMilchmann. This should now be fixed in v4.1.0. I've also introduced a default value for token. If you experience any problems, please let me know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the action only logs errors during the configuration phase and for internal bugs but does not mark the step as failed. This change fixes this by failing the step if any error is thrown (and not caught elsewhere).
See this workflow run for example without this change and this run with the change.