-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: error->importing picker from react-native core is deprecated #3230
Conversation
"@react-native-community/picker" added to dependecies
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's incorrect way to import Picker
. Should be named import:
import { Picker } from '@react-native-community/picker';
See example from docs:
https://www.npmjs.com/package/@react-native-community/picker#usage-1
@akhil-geekyants @sankhadeeproy007 @SupriyaKalghatgi @shivrajkumar |
fixed the imports. |
I have started a new project and it's causing me issues with this error. Seems like this needs to go in quite quick. This happens whenever I use any component that has a dependency on the picker.
EDIT: It doesn't actually prevent the app from working but does give an ugly ERROR message when it's re-bundled to the device. |
@shivrajkumar Thanks for merging 👍 How about making release and publish it to NPM? |
Friendly reminder 🔝 |
Ping |
Please |
It's almost there. "main": "dist/src/index.js", if we wanna edit and have a temp test, use reason: solutions: in ourAppProject/package.json "native-base": "^2.13.14", or fork https://github.com/GeekyAnts/NativeBase.git to your own git cd ourAppProjectPath |
Any ETA for a new release containing this change? |
Guys, I don't want to be annoying, but could you make a release? P.S. CI/CD can resolve this issue by automatically deploy and release after merging to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
Can we please have an update on the release? |
We're waiting for two months just for making a release to NPM. Why it's so hard? Give me a contributor rights, so I can do that, because seems like nobody cares about this project from the core team. |
common!!!!!!!!!!!!! |
Ping |
Ping again. Can someone please fix this? |
Now it's @react-native-picker/picker and not '@react-native-community/picker' anymore :( Any plan to update to this new library ? |
Ohhh, really? Again renamed... That's why I don't like react native, no any stability |
Yes I don't understand why it's change so frequently. It looks like there is no more projetc in react-community |
@arochedy if you can make a PR it'll be great 👍 |
@alexandrtovmach I have made a PR to fix this issue over at #3321 |
imported picker from @react-native-community/picker