check citation doi if empty (wikidata), skip if empty

GaziYucel · Apr 30, 2024 · 6d0f537 · 6d0f537
1 parent 820da92
commit 6d0f537
Showing 1 changed file with 4 additions and 5 deletions.
diff --git a/classes/External/Wikidata/Inbound.php b/classes/External/Wikidata/Inbound.php
@@ -81,12 +81,11 @@ public function execute(): bool
             /* @var CitationModel $citation */
             $citation = ClassHelper::getClassWithValuesAssigned(new CitationModel(), $citations[$i]);
 
-            if (!empty($citation->wikidataId)) continue;
+            if (!empty($citation->wikidataId) || empty($citation->doi)) continue;
 
-            if(!empty($citation->doi)){
-                $citation = $this->processCitation($citation);
-                $citation->wikidataId = Wikidata::removePrefix($citation->wikidataId);
-            }
+            $citation = $this->processCitation($citation);
+
+            $citation->wikidataId = Wikidata::removePrefix($citation->wikidataId);
 
             $citations[$i] = $citation;
         }