add types to Menu component #185
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| import type Items from './menu/items'; | ||
|
|
||
| interface MenuSignature { | ||
| Args: { |
There was a problem hiding this comment.
are all of these public API?
seems like many are private and shouldn't be exposed
There was a problem hiding this comment.
thanks, good catch, these types were actually meant to be on the button component.
I have removed these now. If you find others, I would be happy to know.
johanrd
commented
Dec 5, 2023
| guid = `${guidFor(this)}-tailwindui-menu-item`; | ||
| element; | ||
| element?: HTMLElement | null; |
There was a problem hiding this comment.
TS complained about this one, probably since the element is registered from the item-element component, and not item directly?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.