-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Which components are public API? #94
Comments
like, for Public API:
but, the following is private API:
|
👍 I think it's reasonable that top level components are public and any yielded components are private. |
@GavinJoyce that's how I understand it as well!
@NullVoxPopuli 🤯 I had no idea that was the case -- do you have a link to more information? |
It's a feature of the VM upgrade in 3.25+ that lets components-as-values be a thing, made a demo: https://github.com/GavinJoyce/ember-headlessui/pull/119/files#diff-268d073b63281f34748203ce9d28f671ae6be574d74ea8d0407154b0d3452924R8 |
Traditionally, all components used must have app-re-exports, but with Ember 3.25+, we can get around that -- and there may be some internal organization benefits to having total control over implementation details if we can ensure that certain components, like, list-box/button is private (in this case, the only intended use is through the yield of the listbox component, which pre-wires up a bunch of stuff -- which maybe we want to restrict what folks can do?)
The text was updated successfully, but these errors were encountered: