Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version to 1.2.0 ahead of release #124

Merged
merged 2 commits into from
Feb 25, 2023
Merged

Conversation

colindean
Copy link
Collaborator

I think a minor version bump is warranted because introducing a platform-dependent dependency with its own dependency tree may have surprising behavior to someone on an Intel Mac who suddenly sees tensorflow-macos installed instead of tensorflow.

(this is also primarily meant to exercise the new build and release workflow)

@colindean
Copy link
Collaborator Author

@GantMan looks like you need to set up the tokens still, per #123 (comment)

@colindean
Copy link
Collaborator Author

Actually, do that and then merge #126 before this.

I think a minor version bump is warranted because introducing a platform-dependent dependency with its own dependency tree may have surprising behavior to someone on an Intel Mac who suddenly sees tensorflow-macos installed instead of tensorflow.
@colindean
Copy link
Collaborator Author

Rebased and ready to go. I checked the built package and it looks OK.

@colindean colindean merged commit 4539fd5 into GantMan:master Feb 25, 2023
@colindean colindean deleted the patch-1 branch February 25, 2023 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant