ability to have text fields in your RedAlert alerts... works in iOS 7… and 8. enjoy :)#9
Closed
mixflame wants to merge 1 commit intoGantMan:masterfrom
Closed
ability to have text fields in your RedAlert alerts... works in iOS 7… and 8. enjoy :)#9mixflame wants to merge 1 commit intoGantMan:masterfrom
mixflame wants to merge 1 commit intoGantMan:masterfrom
Conversation
Owner
|
Hey! I love this. Funny, is that I JUST had an API syntax conversation with @derekgreenberg on the best way to implement #8 I checked in with him and he says he's nearly done with a very nice API which will be shared in iOS7 and iOS8. He's going to massage your logic in with his PR which will give us a unified syntax, and TEMPLATES! I hope that's ok, I plan to credit you both in the README docs. 😃 |
Author
|
@GantMan yeah, totally. up to you. 👍 for now, this serves my purposes, but when @derekgreenberg's work is merged (and published) I will upgrade my app to the new style. :) thanks! |
Owner
|
closing this now. Derek has finalized his PR. Both of you are mentioned in the readme 👍 |
Author
|
wooohooo!!!! yaaaay!!!! thanks @GantMan :D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
yo all.
I saw #8 and I needed this feature. And while we use Bubblewrap, I didn't want to, when I already have a dedicated library for alerts (RedAlert.) Also, BW didn't seem to support iOS 8 fully. And I don't want the warning.
So I wrote this for ya. I tried to share the API as much as possible between 7 and 8, but truth is the style is a bit different... anyway I'm happy with what I did. There's 2 tests I added as well. Couldn't figure out how to test if the text is returned, but I hand tested it. But don't take my word for it.
iOS 7
iOS8
Thanks, and good luck! - @jsilverMDX
edit: I forgot to say. Happy 4th of July! 🎆