Skip to content

7#3

Merged
GantMan merged 15 commits intoGantMan:masterfrom
skellock:7
Apr 25, 2015
Merged

7#3
GantMan merged 15 commits intoGantMan:masterfrom
skellock:7

Conversation

@skellock
Copy link
Copy Markdown
Contributor

Things to chat about before accepting:

Structural Changes

  • lib/*_provider.rb now contain the heart of the implementation.
  • UIAlertAction objects are now AlertAction to be iOS 7 friendly
  • The internals changed just enough that i had to rework all existing tests. Sorry. The positive side now is there's many more!

Breaking Changes

  • I pulled working with UIAlertView directly now that it is intrinsically supported.
  • I removed the ability to pass in UIActionAlert actions. We could actually bring them back if you really wanted to if we put in some branches around ios version.

Other Fixes

  • The whole title.to_sym thing you were doing was clever! But an edge case broke it when localization was switched to 🇫🇷. So I introduced the ability to set it explicitly with a :tag and falling back to the way you've done it.

Problems

  • There is some serious fugly in the way I've handled delegate for iOS 7. Check out the end of the alert method. I feel like you may know the right thing to do. I couldn't stop the fail 🚋. :shipit:
  • The unit tests don't even run when I change the simulator AND deployment target to iOS 7. I think this is rake spec + RubyMotion issue though. Just a heads up.

Other Stuff

  • I bumped the gemspec to 1.0.0. Time to shine.
  • Thanks for your guidance in planning this PR.

GantMan added a commit that referenced this pull request Apr 25, 2015
@GantMan GantMan merged commit d3b01c7 into GantMan:master Apr 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants