Merged
Conversation
GantMan
added a commit
that referenced
this pull request
Apr 25, 2015
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Things to chat about before accepting:
Structural Changes
lib/*_provider.rbnow contain the heart of the implementation.UIAlertActionobjects are nowAlertActionto be iOS 7 friendlyBreaking Changes
UIAlertViewdirectly now that it is intrinsically supported.Other Fixes
title.to_symthing you were doing was clever! But an edge case broke it when localization was switched to 🇫🇷. So I introduced the ability to set it explicitly with a:tagand falling back to the way you've done it.Problems
alertmethod. I feel like you may know the right thing to do. I couldn't stop the fail 🚋.rake spec+ RubyMotion issue though. Just a heads up.Other Stuff