Skip to content

Conversation

GangGreenTemperTatum
Copy link
Owner

@GangGreenTemperTatum GangGreenTemperTatum commented May 9, 2025

feat: interval id polling

Key Changes:

Added:

  • polling ID and state to expose new API methods to control polling from the frontend

Generated Summary:

  • Added polling functionality to improve request handling.
  • Introduced startPolling, stopPolling, and togglePolling functions to manage the polling state.
  • Modified init method to register new API endpoints for polling controls:
    • togglePolling
    • isPollingActive
  • Created a new useCaidoSDK composable for easier access to the SDK in Vue components.
  • Updated the App.vue component to include a button for toggling polling and display its status.
  • Reorganized code for better maintainability and clarity.
  • Potential impact includes improved performance through efficient request handling and better user experience with polling controls.

This summary was generated with ❤️ by rigging

Copy link

github-actions bot commented May 9, 2025

⚠️ TypeScript Type Check Warnings

The build succeeded, but TypeScript found type issues in your code that should be addressed:

Scope: 2 of 3 workspace projects
packages/backend typecheck$ tsc --noEmit
packages/backend typecheck:   Type 'CustomEvent<D>' is missing the following properties from type 'Event': bubbles, cancelBubble, cancelable, composed, and 17 more.
packages/backend typecheck: src/index.ts(259,26): error TS2339: Property 'setComment' does not exist on type 'RequestsSDK'.
packages/backend typecheck: src/index.ts(260,26): error TS2339: Property 'setTag' does not exist on type 'RequestsSDK'.
packages/backend typecheck: src/index.ts(286,15): error TS2339: Property 'toast' does not exist on type 'SDK<{}, {}>'.
packages/backend typecheck: src/index.ts(287,13): error TS2339: Property 'toast' does not exist on type 'SDK<{}, {}>'.
packages/backend typecheck: src/index.ts(291,15): error TS2339: Property 'toast' does not exist on type 'SDK<{}, {}>'.
packages/backend typecheck: src/index.ts(292,13): error TS2339: Property 'toast' does not exist on type 'SDK<{}, {}>'.
packages/backend typecheck: src/index.ts(301,13): error TS2339: Property 'toast' does not exist on type 'SDK<{}, {}>'.
packages/backend typecheck: src/index.ts(302,11): error TS2339: Property 'toast' does not exist on type 'SDK<{}, {}>'.
packages/backend typecheck: src/index.ts(405,9): error TS2339: Property 'proxy' does not exist on type 'SDK<DefineAPI<{ checkRequest: (sdk: SDK<{}, {}>, requestId: string) => Promise<string>; togglePolling: (sdk: SDK<{}, {}>) => boolean; isPollingActive: () => boolean; }>, {}>'.
packages/backend typecheck: src/index.ts(453,9): error TS2339: Property 'commands' does not exist on type 'SDK<DefineAPI<{ checkRequest: (sdk: SDK<{}, {}>, requestId: string) => Promise<string>; togglePolling: (sdk: SDK<{}, {}>) => boolean; isPollingActive: () => boolean; }>, {}>'.
packages/backend typecheck: Failed
/home/runner/work/MethodCheck/MethodCheck/packages/backend:
 ERR_PNPM_RECURSIVE_RUN_FIRST_FAIL  backend@0.0.0 typecheck: `tsc --noEmit`
Exit status 2

These warnings won't block the PR from being merged, but fixing them is recommended.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🚨 [BUG] - Caido Feedback - Improvement interval id so the user can have a "disable Polling" button

1 participant