Skip to content

Document how to draw a new tile in Adobe Illustrator#81

Merged
delvh merged 6 commits intomainfrom
illustrator
Jul 20, 2022
Merged

Document how to draw a new tile in Adobe Illustrator#81
delvh merged 6 commits intomainfrom
illustrator

Conversation

@leonleoff
Copy link
Contributor

No description provided.

@leonleoff leonleoff requested review from delvh and madebyTimo July 16, 2022 14:51
Copy link
Contributor

@delvh delvh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I don't like having screenshots in German too much, I can at least accept it there more than in the code.

Copy link
Contributor

@madebyTimo madebyTimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additionally to the suggestions from @delvh please rename dev-manuals/illustrator/32x32px_Zeichenfläche 1.png to an meaningful english filename.
I think it would be also a good option to move the pictures into a subfolder cause they are onlz needed for the manual in the .md file.

@madebyTimo
Copy link
Contributor

please also take a look at our Repository Guide

@delvh delvh changed the title Illustrator Document how to draw a new tile in Adobe Illustrator Jul 16, 2022
@delvh
Copy link
Contributor

delvh commented Jul 16, 2022

Also, there is an entry missing in dev-manuals/index.rst.
Please read dev-manuals/readthedocs/add-folder.md to see how to fix that.

@delvh
Copy link
Contributor

delvh commented Jul 17, 2022

@leonleoff will you implement the changes, or do I have to take this PR over?

@delvh delvh requested a review from madebyTimo July 20, 2022 17:39
@delvh delvh self-assigned this Jul 20, 2022
@delvh delvh added the documentation Improvements or additions to documentation label Jul 20, 2022
Copy link
Contributor

@madebyTimo madebyTimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well done improvements

Co-authored-by: madebyTimo <44726248+madebyTimo@users.noreply.github.com>
@delvh delvh merged commit b6fb8ef into main Jul 20, 2022
@delvh delvh deleted the illustrator branch July 20, 2022 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants