Merged
Conversation
Collaborator
Author
|
a lot of the markdown fixes are according to best practice part of https://www.markdownguide.org/basic-syntax/ |
delvh
changed the title
delvh
reviewed
Jun 29, 2022
Contributor
delvh
left a comment
delvh
left a comment
There was a problem hiding this comment.
Regarding the READMEs whose only purpose is to provide a TOC: I explicitly removed them because they don't work well with ReadTheDocs, each file would need to be manually disabled, and it is also annoying to keep them up to date.
delvh
force-pushed
the
maintenance/rename-files-and-fix-grammar
branch
from
6571eb7 to
d3636fa
Compare
Co-authored-by: delvh <dev.lh@web.de>
Co-authored-by: delvh <dev.lh@web.de>
Co-authored-by: delvh <dev.lh@web.de>
Co-authored-by: delvh <dev.lh@web.de>
Co-authored-by: delvh <dev.lh@web.de>
Co-authored-by: delvh <dev.lh@web.de>
Co-authored-by: delvh <dev.lh@web.de>
Co-authored-by: delvh <dev.lh@web.de>
Co-authored-by: delvh <dev.lh@web.de>
Co-authored-by: delvh <dev.lh@web.de>
cdingm
commented
Jun 30, 2022
cdingm
commented
Jun 30, 2022
cdingm
commented
Jun 30, 2022
Collaborator
Author
cdingm
left a comment
cdingm
left a comment
There was a problem hiding this comment.
The new linking doesnt work, what was the problem with the old?
we decided on this version, and i also asked once again in the discord about this matter
delvh
approved these changes
Jun 30, 2022
Contributor
|
Is there still the need for a second review? |
Collaborator
Author
|
I dont think so, i believe we said only one needed for docs? So I already merged it😅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes Gamify-IT/issues#56