Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Orb of Ankou 1.20 #882

Merged
merged 5 commits into from
Sep 22, 2023
Merged

Orb of Ankou 1.20 #882

merged 5 commits into from
Sep 22, 2023

Conversation

BPR02
Copy link
Member

@BPR02 BPR02 commented Jun 11, 2023

Feature Complete for 1.20:

  • Sniffers can drop pneumas (Retreating and Sniffing)
  • Sniffing (sneak hold) allows the player to sniff up torchflower seeds and pitcher pods. Once one is dug up there's an 8 minute cooldown. Sneak must be held for at least 5 seconds before an item can be dug up.
  • Camels can drop pneumas (Retreating and Dashing)
  • Dashing (sneak charge) allows the player to dash up to about 12 blocks forward (depending how long they sneak) and a bit more than 1 block up

Changes:

  • Support for up to Looting X (previously anything above looting III wouldn't drop anything)
  • Magma Cube drop rates reduced
  • Dolphin drop rates reduced
  • Axolotl drop rates increased

Technical:

  • The beet script now reads a CSV file in the source code and generates the loot tables for each mob. This was previously done with an offline script and separate sheet.
  • The beet script generates the predicates that indicate if a player has a pneuma equipped

Bug Fixes:

  • Some pneumas were broken in 1.19.4 due to damage type changes
  • Sneak charge pneuma would activate when the sneak number was greater than 3 which is too low after the tick change in Orb of Ankou 1.19 #780 (it wouldn't do anything, but it was unnecessary code being run)

BPR02 added 4 commits June 9, 2023 13:07
new:
- support looting levels up to 10 (configurable in script)
these changes were made, but never pushed:
- reduce magma cube drops
- reduce dolphin drops
- increase axolotl drops
- camel: retreating, dashing(new)
  - dashing (sneak charge) allows the player to dash up to about 12 blocks forward (depending how long they sneak) and a bit more than 1 block up
- sniffer: retreating, sniffing(new)
  - sniffing (sneak hold) allows the player to sniff up torchflower seeds and pitcher pods. Once one is dug up there's an 8 minute cooldown. Sneak must be held for at least 5 seconds before an item can be dug up.
- fixed a bug with sneak charge pneumas activating when sneak number is too low
Script now generates the predicates to check if a player has a pneuma equipped
Use 1.19.4+ damage type tags
@Bloo-dev Bloo-dev added feature-update An additional feature has been added to a module needs-testing Requires in-game testing labels Jun 12, 2023
@@ -0,0 +1,182 @@
-Run beet to update columns 4-9

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had no idea you could add comments to csvs

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a normal cell actually, I just skip the first few lines when parsing it then print that out when rewriting it

@Bloo-dev
Copy link
Member

Bloo-dev commented Sep 8, 2023

That's a nice use of a csv! I'll test this in-game this weekend.

Copy link
Member

@TheThanathor TheThanathor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this in game and everything works as expected

didn't take a full look at the python file, but from the output that seems to work as well

@Bloo-dev Bloo-dev merged commit 62303d7 into Gamemode4Dev:master Sep 22, 2023
2 checks passed
github-actions bot pushed a commit that referenced this pull request Sep 22, 2023
* Use Script to generate loot tables

new:
- support looting levels up to 10 (configurable in script)
these changes were made, but never pushed:
- reduce magma cube drops
- reduce dolphin drops
- increase axolotl drops

* Camel and Sniffer Pneumas

- camel: retreating, dashing(new)
  - dashing (sneak charge) allows the player to dash up to about 12 blocks forward (depending how long they sneak) and a bit more than 1 block up
- sniffer: retreating, sniffing(new)
  - sniffing (sneak hold) allows the player to sniff up torchflower seeds and pitcher pods. Once one is dug up there's an 8 minute cooldown. Sneak must be held for at least 5 seconds before an item can be dug up.
- fixed a bug with sneak charge pneumas activating when sneak number is too low

* Use script to generate pneuma predicates

Script now generates the predicates to check if a player has a pneuma equipped

* Update damage types

Use 1.19.4+ damage type tags
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-update An additional feature has been added to a module needs-testing Requires in-game testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants