Blasting Maces #1255
Open
Blasting Maces #1255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheThanathor
requested changes
Jan 23, 2026
Member
TheThanathor
left a comment
TheThanathor
left a comment
There was a problem hiding this comment.
I've left a few comments for small issues, adding some bigger points here:
- I'm not really a fan of the level 2 of this enchantment, breaking a 5x5 area "feels" off to me, it's kind of breaking with the one-block-at-a-time philosophy (yes I know the 3x3 does as well, but it's kind of okay somehow?) Personally I'd like to more if it's just the single level for the enchantment, but good to get more views on this.
- The biggest improvement that could be made is to make use of local coordinates (the
^things) so you don't need different functions for each orientation. - In my opinion it would make more sense for the breaking orientation to depend on the face of the block the player targeted instead of their facing direction (this might be hard to figure out though)
- Also up for debate, should the breaking count as if it was broken by an explosion? (so metallurgy drops), it would make sense lore wise. The Mace is late game enough that I feel it would probably not be too overpowered, but need more input on this.
I've tested the module in-game and everything worked as expected, though I didn't test the dark magic Guidebook
Member
There was a problem hiding this comment.
This doesn't seem to be intentional
Author
There was a problem hiding this comment.
This was changed automatically after running beet. Could be due to the following lines inside guidebook/blasting_maces.json
"icon": {
"id": "minecraft:mace"
},
Contributor
There was a problem hiding this comment.
Oh did you run the build for release code or dev? Every time i run the build for release it updates the skin cache and i just discard the change
Author
There was a problem hiding this comment.
I did "uv run beet dev". Guess I should removed it then
Contributor
There was a problem hiding this comment.
Oh hmm, yeah this definitely isn't your fault, its just a weird oddity that's been happening that nobody's gotten around to 😅
gm4_blasting_maces/data/gm4_blasting_maces/enchantment/blasting.json
Outdated
Show resolved
Hide resolved
gm4_blasting_maces/data/gm4_blasting_maces/function/init.mcfunction
Outdated
Show resolved
Hide resolved
gm4_blasting_maces/data/gm4_blasting_maces/function/mace/add_tool_component.mcfunction
Outdated
Show resolved
Hide resolved
gm4_blasting_maces/data/gm4_blasting_maces/function/mace/remove_tool_component.mcfunction
Outdated
Show resolved
Hide resolved
gm4_blasting_maces/data/gm4_blasting_maces/function/player/blast.mcfunction
Outdated
Show resolved
Hide resolved
gm4_blasting_maces/data/gm4_blasting_maces/function/player/modify_mace_durability.mcfunction
Outdated
Show resolved
Hide resolved
Co-authored-by: Djones <73304324+TheThanathor@users.noreply.github.com>
Co-authored-by: Djones <73304324+TheThanathor@users.noreply.github.com>
runcows
reviewed
Jan 24, 2026
gm4_blasting_maces/data/gm4_blasting_maces/guidebook/blasting_maces.json
Outdated
Show resolved
Hide resolved
Co-authored-by: Djones <73304324+TheThanathor@users.noreply.github.com>
Co-authored-by: Djones <73304324+TheThanathor@users.noreply.github.com>
…troy_block.mcfunction Co-authored-by: Djones <73304324+TheThanathor@users.noreply.github.com>
Author
|
Changes
|
drodo-mc
commented
Jan 24, 2026
| "gm4_potion_liquids:liquids/poison", | ||
| "gm4_potion_liquids:liquids/regeneration", | ||
| "gm4_potion_liquids:liquids/strength", | ||
| "gm4_potion_liquids:liquids/swiftness" |
Author
There was a problem hiding this comment.
This was also automatically changed after running beet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blasting Maces module submission.
Adds a new Blasting enchantment that allows the player to dig areas of 3x3 (with Blasting I) and 5x5 (with Blasting II). The breaking area is directional, depending on where the player is looking. Durability loss scales with the number of blocks broken.
The module also takes the grindstone into account, adding or removing the tool component when the item is enchanted or when the enchantment is removed via a grindstone.