Skip to content

Conversation

@BPR02
Copy link
Member

@BPR02 BPR02 commented Nov 17, 2025

This PR adds a new config option to the resource pack to modify the base item model definition. This is specifically useful when finer control over the base item model is needed. Previously this functionality was not available and with our resource pack workflow, certain features were not implementable. This PR allows the entire "model" JSON object to be modified.

E.g. to acheive the following custom model data:

{
  "threshold": 3420002,
  "model": {
    "type": "minecraft:model",
    "model": "gm4_scuba_gear:item/flippers",
    "tints": [
      {
        "type": "minecraft:dye",
        "default": -14455863
      }
    ]
  }
}

The following base_model config can be used:

model_data:
  - item: leather_boots
    reference: item/flippers
    template: generated_overlay
    base_model: 
      tints: 
        - type: minecraft:dye
          default: -14455863

Or alternatively with JSON:

model_data:
  - item: leather_boots
    reference: item/flippers
    template: generated_overlay
    base_model: {
      "tints": [
        {
          "type": "minecraft:dye",
          "default": -14455863
        }
      ]
    }

BPR02 added a commit to BPR02/GM4_Datapacks that referenced this pull request Nov 17, 2025
@Bloo-dev Bloo-dev added the tool This is related to our build pipeline label Nov 17, 2025
Copy link
Member

@SpecialBuilder32 SpecialBuilder32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty simple and straightforward to me.

@misode misode merged commit f6d4824 into Gamemode4Dev:master Nov 19, 2025
7 of 8 checks passed
github-actions bot pushed a commit that referenced this pull request Nov 20, 2025
* add base model config to resource pack plugin

* document base_model config

* update base_model config example
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tool This is related to our build pipeline

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants