This repository was archived by the owner on Jan 3, 2023. It is now read-only.
Fixes some issues by PVS-Studio static code analyzer #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As it is checked in two places later, i assume it is expected to be null sometimes (out of memory?).
dimhotepus
changed the title
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First, thank you for scheduler and especially for research links on Intel article page! Saw a lot of implementations, but it is hard to understand what is going on without solid theoretical foundation.
Second, code quality is really high. This is rare case i can read and understand underlying data structures and algorithms. Nice job!
Third, I've a habit to run some static code analyzers before using some interesting project as my one dependency. So PVS-Studio + MSVC integrated static analyzer found some suspicious places. Could you please, take a look?
Product page: https://www.viva64.com/en/pvs-studio/
How to use for free (almost): https://www.viva64.com/en/b/0600/