This repository was archived by the owner on Jan 3, 2023. It is now read-only.
Debug code to assert Task's data destructor are called when type is non trivially destructible. #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is non trivially destructible.
LuisAntonRebollo
force-pushed
the
feature_task_data_destructor_assert
branch
from
bcd68f3 to
224bffb
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A different idea related the data destructors.
This code only works when GTS_ASSERT are enabled, in this way the performance in release in not affected.
The new asserts ensure Task::destructData will be called before any other data initialization or Task destruction.
Note: this PR is mostly for discussion about the idea, as i feel i have not sufficient knowledge on how GTS works.