Skip to content

fix(darwin): fix address assignment on MacOS #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
M0dEx wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix(darwin): fix address assignment on MacOS #74

M0dEx wants to merge 4 commits into from

Conversation

@M0dEx
Copy link

@M0dEx M0dEx commented Apr 8, 2023 •
edited
Loading

This PR fixes multiple issues with address assignment on MacOS:

  • bad dummy socket IP which caused all address operations to throw EINVAL.
  • address assignment for TUN interfaces on MacOS works differently than on Linux, as you do not only specify the address of the interface, but also the destination address/network

Any changes, ideas and code style improvements welcome!

Fixes #69.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

add_address returns EINVAL for any address in darwin InterfaceHandle

1 participant

@M0dEx