Skip to content

Fix an issue where the release action fails #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 4, 2025

Conversation

ChrisDufourMB
Copy link
Collaborator

Description

Fixes an issue in the npm deploy script where the tests would fail as a result of --doc being set twice, once in the deno.json, and again in ts_serialize_release.yml

Things to look at

  • Test coverage
  • Code Style
  • Documentation (README.md, CHANGELOG.md, etc..)

Copy link
Contributor

@WillForrestMindBridge WillForrestMindBridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It turns out 100% code coverage still can't cover release scripts...

@ChrisDufourMB ChrisDufourMB merged commit 4569e57 into develop Jun 4, 2025
14 checks passed
@ChrisDufourMB ChrisDufourMB deleted the fix-release-ci-v2.1.0 branch June 4, 2025 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants