Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add tabs storybook #92

Merged
merged 3 commits into from
May 30, 2023
Merged

doc: add tabs storybook #92

merged 3 commits into from
May 30, 2023

Conversation

Yuwen-ctw
Copy link
Contributor

@Yuwen-ctw Yuwen-ctw commented May 27, 2023 •
edited
Loading

Why need this change? / Root cause:

  • Add documentation to make more clearer

Changes made:

  • Added of Tab's Storybook documentation.
  • Adjust the tabs backgorund color and the tab active color .
  • Change the arg of renderTabPaneContent prop from activeKey to activeTabItem
  • Adjust comment.

Test Scope / Change impact:

  • Unit test
  • Style
  • Developer now could put data in tabItem and use it when render tabPane

Issue

@Yuwen-ctw Yuwen-ctw added documentation Improvements or additions to documentation, ex, storybook, readme refactor refactor the changes already merged. labels May 27, 2023
@Yuwen-ctw Yuwen-ctw self-assigned this May 27, 2023
@Yuwen-ctw Yuwen-ctw linked an issue May 27, 2023 that may be closed by this pull request
新增 Tabs的 Storybook 與樣式調整 #91
Closed
Parkerhiphop
Parkerhiphop reviewed May 27, 2023
View reviewed changes
@Parkerhiphop Parkerhiphop merged commit 61431ec into main May 30, 2023
@Parkerhiphop Parkerhiphop deleted the feature/doc/tabs branch May 30, 2023 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HongLinLiao HongLinLiao HongLinLiao approved these changes

@Parkerhiphop Parkerhiphop Parkerhiphop approved these changes

Assignees

@Yuwen-ctw Yuwen-ctw

Labels
documentation Improvements or additions to documentation, ex, storybook, readme refactor refactor the changes already merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

新增 Tabs的 Storybook 與樣式調整
3 participants
@Yuwen-ctw @HongLinLiao @Parkerhiphop