Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: 📝 add search bar story book #83

Merged
merged 4 commits into from
May 28, 2023
Merged

doc: 📝 add search bar story book #83

merged 4 commits into from
May 28, 2023

Conversation

JohnsonMao
Copy link
Contributor

@JohnsonMao JohnsonMao commented May 26, 2023 •
edited
Loading

Why need this change? / Root cause:

  • Added of searchBar's Storybook documentation.
  • Refactor of search bar style.
  • Removing unnecessary onEnter and Composition event.

Changes made:

  • Added search bar Storybook

Test Scope / Change impact:

  • unit test on the search bar
  • change search bar style

Issue

@JohnsonMao JohnsonMao added documentation Improvements or additions to documentation, ex, storybook, readme refactor refactor the changes already merged. labels May 26, 2023
@JohnsonMao JohnsonMao self-assigned this May 26, 2023
@HongLinLiao HongLinLiao merged commit e997dc6 into main May 28, 2023
@HongLinLiao HongLinLiao deleted the doc/search-bar branch May 28, 2023 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Parkerhiphop Parkerhiphop Parkerhiphop approved these changes

@HongLinLiao HongLinLiao Awaiting requested review from HongLinLiao

Assignees

@JohnsonMao JohnsonMao

Labels
documentation Improvements or additions to documentation, ex, storybook, readme refactor refactor the changes already merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

新增 search bar 的 Storybook 與樣式重構
3 participants
@JohnsonMao @Parkerhiphop @HongLinLiao