refactor: pre-commit & pre-push refinement #78
Merged
+47
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HongLinLiao
approved these changes
May 26, 2023
kylemocode
force-pushed
the
refactor/pre-commit-and-pre-push-refine
branch
from
1fa22ae to
e3078c1
Compare
Parkerhiphop
approved these changes
May 27, 2023
Parkerhiphop
approved these changes
May 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why need this change? / Root cause:
lint-staged.config.js, it will filter the files that got changed in the commit, and its logic is like below:js,jsx,ts,tsx: run prettier & eslintcss,scss: prettier (maybe we can add stylelint in the future)json,md,mdx,html,yml,yaml: prettierand it will add the changed files to staged workspace automatically
pre-pushscript because I think that we can rely on CI to run the tests. Otherwise, as the number of test cases increases in the future, placing testing in the pre-push step would affect the efficiency of development.Changes made:
Test Scope / Change impact:
Issue