Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/login page v2 #384

Merged
merged 33 commits into from
May 3, 2024
Merged

feat/login page v2 #384

merged 33 commits into from
May 3, 2024

Conversation

physicsSorcererKing
Copy link
Contributor

@physicsSorcererKing physicsSorcererKing commented Apr 28, 2024

Why need this change? / Root cause:

  • New UI:
    • BoxFancy (Polymorphic Box with Gradient border)
    • ButtonV2 (Polymorphic Button implemented with BoxFancy)
  • New icons
  • New Login Page

Changes made:

  • components/shared/BoxFancy
  • components/shared/Button/v2
  • components/shared/Icon/icons
  • lib/types.ts
  • pages/login.tsx
  • public/images/v2
  • tailwind.config.js

Test Scope / Change impact:

Issue

@physicsSorcererKing physicsSorcererKing linked an issue Apr 28, 2024 that may be closed by this pull request
2 tasks
@physicsSorcererKing physicsSorcererKing changed the title Feat/login page v2 feat/login page v2 Apr 28, 2024
@github-actions github-actions bot added the feature New Feature label Apr 28, 2024
@ricksu978 ricksu978 requested a review from JohnsonMao April 28, 2024 12:07
@physicsSorcererKing
Copy link
Contributor Author

Button V2 的 disabled 似乎沒做好效果,我有空再處理

Copy link
Contributor

@JohnsonMao JohnsonMao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

推薦您先看過 https://ithelp.ithome.com.tw/articles/10308018
這篇文章後,我相信您會有新的想法,
重構完我再來 Review

Copy link

sonarqubecloud bot commented May 1, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
2.9% Duplication on New Code

See analysis details on SonarCloud

@GaaSBot
Copy link

GaaSBot commented May 1, 2024

Knip Scan Result for d36c898

Unused files (9)
Unused files (9)
.bundlewatch.config.js
components/shared/Chat/ChatContent.tsx
components/shared/Chat/ChatMessage.tsx
components/shared/Chat/index.tsx
configs/i18nConfigs.ts
lighthouserc.js
reset.d.ts
scripts/knipScanReporter.js
scripts/lhciScanReporter.js
Unused dependencies (2)
Unused dependencies (2)
@svgr/webpack package.json
sharp package.json
Unused devDependencies (5)
Unused devDependencies (5)
@actions/github package.json
@octokit/core package.json
@storybook/blocks package.json
@storybook/testing-library package.json
@total-typescript/ts-reset package.json
Unused exported types (2)
Unused exported types (2)
ChatProps type components/shared/Chat/v2/Chat.tsx
ChatHeaderProps type components/shared/Chat/v2/ChatHeader.tsx
Unused exported types in namespaces (1)
Unused exported types in namespaces (1)
BaseBoxFancyProp interface components/shared/BoxFancy/BoxFancy.tsx
Configuration issues (1)
Configuration issues (1)
Unused item in ignoreDependencies: @next/bundle-analyzer

@GaaSBot
Copy link

GaaSBot commented May 1, 2024

🤖 Lighthouse Scan Result for d36c898

/rooms
Metric Value
Performance 73
Seo 78
Accessibility 78
HTML Report for LHCI Scan Report Link
/rooms/abc
Metric Value
Performance 77
Seo 78
Accessibility 64
HTML Report for LHCI Scan Report Link
/login
Metric Value
Performance 75
Seo 78
Accessibility 93
HTML Report for LHCI Scan Report Link

@JohnsonMao JohnsonMao self-requested a review May 3, 2024 14:24
Copy link
Contributor

@JohnsonMao JohnsonMao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

如果您很清楚統一使用 useCallback 與 useMemo 要付出的代價的話,也是可以的。

@JohnsonMao JohnsonMao merged commit 562077c into main May 3, 2024
7 checks passed
@JohnsonMao JohnsonMao deleted the feat/login-page-v2 branch May 3, 2024 14:28
JohnsonMao added a commit that referenced this pull request Jun 1, 2024
…peared

fix: Add IconV2 with new svg settings and revert old Icons changed by PR #384
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v2 - 登入畫面
3 participants