Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: game end not getting the correct room status bug #380

Merged
merged 2 commits into from
Mar 19, 2024

Conversation

JohnsonMao
Copy link
Contributor

Why need this change? / Root cause:

Changes made:

  • fix game end not async room info bug

Test Scope / Change impact:

  • room page

Issue

@JohnsonMao JohnsonMao self-assigned this Mar 19, 2024
@github-actions github-actions bot added the bug Fix something in main label Mar 19, 2024
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@GaaSBot
Copy link

GaaSBot commented Mar 19, 2024

Knip Scan Result for 29d0fd3

Unused files (9)
Unused files (9)
.bundlewatch.config.js
components/shared/Chat/ChatContent.tsx
components/shared/Chat/ChatMessage.tsx
components/shared/Chat/index.tsx
configs/i18nConfigs.ts
lighthouserc.js
reset.d.ts
scripts/knipScanReporter.js
scripts/lhciScanReporter.js
Unused dependencies (2)
Unused dependencies (2)
@svgr/webpack package.json
sharp package.json
Unused devDependencies (5)
Unused devDependencies (5)
@actions/github package.json
@octokit/core package.json
@storybook/blocks package.json
@storybook/testing-library package.json
@total-typescript/ts-reset package.json
Unused exported types (2)
Unused exported types (2)
ChatProps type components/shared/Chat/v2/Chat.tsx
ChatHeaderProps type components/shared/Chat/v2/ChatHeader.tsx
Configuration issues (1)
Configuration issues (1)
Unused item in ignoreDependencies: @next/bundle-analyzer

@GaaSBot
Copy link

GaaSBot commented Mar 19, 2024

🤖 Lighthouse Scan Result for 29d0fd3

/rooms
Metric Value
Performance 73
Seo 78
Accessibility 78
HTML Report for LHCI Scan Report Link
/rooms/abc
Metric Value
Performance 76
Seo 78
Accessibility 64
HTML Report for LHCI Scan Report Link
/login
Metric Value
Performance 47
Seo 80
Accessibility 94
HTML Report for LHCI Scan Report Link

@JohnsonMao JohnsonMao merged commit 5cf5fab into main Mar 19, 2024
7 checks passed
@JohnsonMao JohnsonMao deleted the fix/game-ending-refetch-room-info branch March 19, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix something in main
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 結束遊戲 - 回到房間時,房主變成未準備
2 participants