Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove unnecessary SVG files and consolidate SVG usage into… #345

Merged
merged 1 commit into from
Oct 30, 2023
Merged

refactor: remove unnecessary SVG files and consolidate SVG usage into… #345

merged 1 commit into from
Oct 30, 2023

Conversation

Yuwen-ctw
Copy link
Contributor

Why need this change? / Root cause:

  • New design system released.

Changes made:

  • Removed unused and unnecessary SVG files to reduce clutter and save space.
  • Consolidated the usage of SVG icons into dedicated Icon components, which improves code maintainability and consistency.
  • Made necessary adjustments to other components to accommodate the changes made above.

Test Scope / Change impact:

Issue

@Yuwen-ctw Yuwen-ctw added refactor refactor the changes already merged. spring 13 labels Oct 22, 2023
@Yuwen-ctw Yuwen-ctw self-assigned this Oct 22, 2023
@Yuwen-ctw
refactor: remove unnecessary SVG files and consolidate SVG usage into…
3164752 
… Icon components

- Removed unused and unnecessary SVG files to reduce clutter and save space.
- Consolidated the usage of SVG icons into dedicated Icon components, which improves code maintainability and consistency.
- Made necessary adjustments to other components to accommodate the changes made above.
@Yuwen-ctw Yuwen-ctw force-pushed the refactor/icon-component branch from 5aacc15 to 3164752 Compare October 22, 2023 09:12
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@GaaSBot
Copy link

GaaSBot commented Oct 22, 2023

✅ Knip Scan Result for 3164752

Unused files (9)
Unused files (9)
.bundlewatch.config.js
components/shared/Chat/ChatContent.tsx
components/shared/Chat/ChatMessage.tsx
components/shared/Chat/index.tsx
configs/i18nConfigs.ts
lighthouserc.js
reset.d.ts
scripts/knipScanReporter.js
scripts/lhciScanReporter.js
Unused dependencies (2)
Unused dependencies (2)
@svgr/webpack package.json
sharp package.json
Unused devDependencies (5)
Unused devDependencies (5)
@actions/github package.json
@octokit/core package.json
@storybook/blocks package.json
@storybook/testing-library package.json
@total-typescript/ts-reset package.json
Configuration issues (1)
Configuration issues (1)
Unused item in ignoreDependencies: @next/bundle-analyzer

@GaaSBot
Copy link

GaaSBot commented Oct 22, 2023

🤖 Lighthouse Scan Result for 3164752

/rooms
Metric Value
Performance 64
Seo 78
Accessibility 75
HTML Report for LHCI Scan Report Link
/rooms/abc
Metric Value
Performance 74
Seo 78
Accessibility 64
HTML Report for LHCI Scan Report Link
/login
Metric Value
Performance 46
Seo 80
Accessibility 94
HTML Report for LHCI Scan Report Link

@Yuwen-ctw Yuwen-ctw marked this pull request as draft October 23, 2023 03:34
@Yuwen-ctw Yuwen-ctw marked this pull request as ready for review October 23, 2023 13:03
JohnsonMao
JohnsonMao approved these changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@JohnsonMao JohnsonMao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JohnsonMao JohnsonMao merged commit 8bde0eb into main Oct 30, 2023
@JohnsonMao JohnsonMao deleted the refactor/icon-component branch October 30, 2023 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allyusd allyusd allyusd approved these changes

@JohnsonMao JohnsonMao JohnsonMao approved these changes

@ttpss930141011 ttpss930141011 Awaiting requested review from ttpss930141011

Assignees

@Yuwen-ctw Yuwen-ctw

Labels
refactor refactor the changes already merged. spring 13
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Yuwen-ctw @GaaSBot @allyusd @JohnsonMao