Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: modified MessageType #315

Merged
merged 1 commit into from
Sep 5, 2023
Merged

Conversation

Yuwen-ctw
Copy link
Contributor

Why need this change? / Root cause:

Changes made:

  • Change MessageType and every codes that related

Test Scope / Change impact:

Issue

@Yuwen-ctw Yuwen-ctw added refactor refactor the changes already merged. sprint 9 labels Sep 4, 2023
@Yuwen-ctw Yuwen-ctw self-assigned this Sep 4, 2023
@vercel
Copy link

vercel bot commented Sep 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
game-lobby-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 4, 2023 1:23pm

@Yuwen-ctw Yuwen-ctw force-pushed the refactor/chat-message-type branch from c7f516d to d3b0167 Compare September 4, 2023 13:21
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@GaaSBot
Copy link

GaaSBot commented Sep 4, 2023

Knip Scan Result for d3b0167

Unused files (10)
Unused files (10)
.bundlewatch.config.js
components/shared/Chat/ChatContent.tsx
components/shared/Chat/ChatMessage.tsx
components/shared/Chat/index.tsx
components/shared/Icon/group/news.tsx
configs/i18nConfigs.ts
lighthouserc.js
reset.d.ts
scripts/knipScanReporter.js
scripts/lhciScanReporter.js
Unused dependencies (2)
Unused dependencies (2)
@svgr/webpack package.json
sharp package.json
Unused devDependencies (5)
Unused devDependencies (5)
@actions/github package.json
@octokit/core package.json
@storybook/blocks package.json
@storybook/testing-library package.json
@total-typescript/ts-reset package.json
Configuration issues (1)
Configuration issues (1)
Unused item in ignoreDependencies: @next/bundle-analyzer

@GaaSBot
Copy link

GaaSBot commented Sep 4, 2023

🤖 Lighthouse Scan Result for d3b0167

/rooms
Metric Value
Performance 60
Seo 80
Accessibility 77
HTML Report for LHCI Scan Report Link
/rooms/abc
Metric Value
Performance 74
Seo 80
Accessibility 66
HTML Report for LHCI Scan Report Link
/login
Metric Value
Performance 49
Seo 80
Accessibility 94
HTML Report for LHCI Scan Report Link

Copy link
Contributor

@ttpss930141011 ttpss930141011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@JohnsonMao JohnsonMao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@JohnsonMao JohnsonMao merged commit fe9e41b into main Sep 5, 2023
@JohnsonMao JohnsonMao deleted the refactor/chat-message-type branch September 5, 2023 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor refactor the changes already merged. sprint 9
Projects
None yet
Development

Successfully merging this pull request may close these issues.

調整聊天訊息格式
4 participants