Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: i18n not working on production environment issue #296

Merged
merged 1 commit into from
Aug 31, 2023

Conversation

ttpss930141011
Copy link
Contributor

@ttpss930141011 ttpss930141011 commented Aug 30, 2023

Why need this change? / Root cause:

  • i18n not working on production

Changes made:

  • Change language tag from zh-TW to zh_TW

Test Scope / Change impact:

Issue

@vercel
Copy link

vercel bot commented Aug 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
game-lobby-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 31, 2023 3:09pm

@github-actions github-actions bot added bug Fix something in main and removed don't merge labels Aug 30, 2023
@ttpss930141011 ttpss930141011 changed the title fix: justin test [WIP] fix: justin test Aug 31, 2023
@ttpss930141011 ttpss930141011 changed the title [WIP] fix: justin test [WIP] fix: i18n not working on production environment issue Aug 31, 2023
@ttpss930141011 ttpss930141011 changed the title [WIP] fix: i18n not working on production environment issue fix: i18n not working on production environment issue Aug 31, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@GaaSBot
Copy link

GaaSBot commented Aug 31, 2023

Knip Scan Result for 5a3a467

Unused files (10)
Unused files (10)
.bundlewatch.config.js
components/shared/Chat/ChatContent.tsx
components/shared/Chat/ChatMessage.tsx
components/shared/Chat/index.tsx
components/shared/Icon/group/news.tsx
configs/i18nConfigs.ts
lighthouserc.js
reset.d.ts
scripts/knipScanReporter.js
scripts/lhciScanReporter.js
Unused dependencies (2)
Unused dependencies (2)
@svgr/webpack package.json
sharp package.json
Unused devDependencies (5)
Unused devDependencies (5)
@actions/github package.json
@octokit/core package.json
@storybook/blocks package.json
@storybook/testing-library package.json
@total-typescript/ts-reset package.json
Configuration issues (1)
Configuration issues (1)
Unused item in ignoreDependencies: @next/bundle-analyzer

@GaaSBot
Copy link

GaaSBot commented Aug 31, 2023

🤖 Lighthouse Scan Result for 5a3a467

/rooms
Metric Value
Performance 67
Seo 80
Accessibility 77
HTML Report for LHCI Scan Report Link
/rooms/abc
Metric Value
Performance 75
Seo 80
Accessibility 66
HTML Report for LHCI Scan Report Link
/login
Metric Value
Performance 49
Seo 80
Accessibility 94
HTML Report for LHCI Scan Report Link

@ttpss930141011
Copy link
Contributor Author

先進行 merge 試試看此改動能不能正常運作。

@ttpss930141011 ttpss930141011 merged commit c94e330 into main Aug 31, 2023
@ttpss930141011 ttpss930141011 deleted the fix/justin-test branch August 31, 2023 15:30
@ttpss930141011 ttpss930141011 linked an issue Aug 31, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix something in main
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: i18n Not Working in Production
3 participants