-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: opening gameUrl with token via Iframe #293
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
86e4924
to
f448206
Compare
Kudos, SonarCloud Quality Gate passed!
|
✅ Knip Scan Result for f448206 Unused files (10)
Unused dependencies (2)
Unused devDependencies (5)
Configuration issues (1)
|
🤖 Lighthouse Scan Result for f448206 /rooms
/rooms/abc
/login
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Why need this change? / Root cause:
Changes made:
GameWindow
component with HTML5 iframe tagGameWindow
after received gameUrl from socket.IO serverTest Scope / Change impact:
GameWindow.test.tsx
Issue