Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: opening gameUrl with token via Iframe #293

Merged
merged 1 commit into from
Aug 31, 2023

Conversation

Yuwen-ctw
Copy link
Contributor

@Yuwen-ctw Yuwen-ctw commented Aug 29, 2023

Why need this change? / Root cause:

  • Implement game start feature after received GAME_STARTED message from socket.IO

Changes made:

  • Add GameWindow component with HTML5 iframe tag
  • Combined the gameUrl and token as the source for the GameWindow after received gameUrl from socket.IO server
  • Modify the mock response data of getRooms API

Test Scope / Change impact:

  • Unit-test : GameWindow.test.tsx

Issue

@vercel
Copy link

vercel bot commented Aug 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
game-lobby-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 29, 2023 1:23pm

@Yuwen-ctw Yuwen-ctw force-pushed the feature/open-game-iframe branch from 86e4924 to f448206 Compare August 29, 2023 13:21
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@GaaSBot
Copy link

GaaSBot commented Aug 29, 2023

Knip Scan Result for f448206

Unused files (10)
Unused files (10)
.bundlewatch.config.js
components/shared/Chat/ChatContent.tsx
components/shared/Chat/ChatMessage.tsx
components/shared/Chat/index.tsx
components/shared/Icon/group/news.tsx
configs/i18nConfigs.ts
lighthouserc.js
reset.d.ts
scripts/knipScanReporter.js
scripts/lhciScanReporter.js
Unused dependencies (2)
Unused dependencies (2)
@svgr/webpack package.json
sharp package.json
Unused devDependencies (5)
Unused devDependencies (5)
@actions/github package.json
@octokit/core package.json
@storybook/blocks package.json
@storybook/testing-library package.json
@total-typescript/ts-reset package.json
Configuration issues (1)
Configuration issues (1)
Unused item in ignoreDependencies: @next/bundle-analyzer

@GaaSBot
Copy link

GaaSBot commented Aug 29, 2023

🤖 Lighthouse Scan Result for f448206

/rooms
Metric Value
Performance 67
Seo 80
Accessibility 79
HTML Report for LHCI Scan Report Link
/rooms/abc
Metric Value
Performance 75
Seo 80
Accessibility 69
HTML Report for LHCI Scan Report Link
/login
Metric Value
Performance 50
Seo 80
Accessibility 97
HTML Report for LHCI Scan Report Link

Copy link
Contributor

@ttpss930141011 ttpss930141011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@JohnsonMao JohnsonMao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ttpss930141011 ttpss930141011 merged commit 48da39b into main Aug 31, 2023
@ttpss930141011 ttpss930141011 deleted the feature/open-game-iframe branch August 31, 2023 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Passing Data to Iframe after Game Start feat: Game URL Opening via Iframe
4 participants