Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix i18n not working in production issue #292

Merged
merged 1 commit into from
Aug 30, 2023
Merged

fix i18n not working in production issue #292

merged 1 commit into from
Aug 30, 2023

Conversation

JohnsonMao
Copy link
Contributor

@JohnsonMao JohnsonMao commented Aug 29, 2023

Why need this change? / Root cause:

  • i18n not working in production

Changes made:

  • next-i18next.config.js

Test Scope / Change impact:

Issue

@vercel
Copy link

vercel bot commented Aug 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
game-lobby-web ✅ Ready (Inspect) Visit Preview Aug 29, 2023 0:53am

@github-actions github-actions bot added the bug Fix something in main label Aug 29, 2023
@JohnsonMao JohnsonMao self-assigned this Aug 29, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@JohnsonMao JohnsonMao requested a review from Yuwen-ctw August 29, 2023 12:54
@GaaSBot
Copy link

GaaSBot commented Aug 29, 2023

Knip Scan Result for 824a9c8

Unused files (10)
Unused files (10)
.bundlewatch.config.js
components/shared/Chat/ChatContent.tsx
components/shared/Chat/ChatMessage.tsx
components/shared/Chat/index.tsx
components/shared/Icon/group/news.tsx
configs/i18nConfigs.ts
lighthouserc.js
reset.d.ts
scripts/knipScanReporter.js
scripts/lhciScanReporter.js
Unused dependencies (2)
Unused dependencies (2)
@svgr/webpack package.json
sharp package.json
Unused devDependencies (5)
Unused devDependencies (5)
@actions/github package.json
@octokit/core package.json
@storybook/blocks package.json
@storybook/testing-library package.json
@total-typescript/ts-reset package.json
Configuration issues (1)
Configuration issues (1)
Unused item in ignoreDependencies: @next/bundle-analyzer

@GaaSBot
Copy link

GaaSBot commented Aug 29, 2023

🤖 Lighthouse Scan Result for 824a9c8

/rooms
Metric Value
Performance 67
Seo 80
Accessibility 79
HTML Report for LHCI Scan Report Link
/rooms/abc
Metric Value
Performance 75
Seo 80
Accessibility 69
HTML Report for LHCI Scan Report Link
/login
Metric Value
Performance 49
Seo 80
Accessibility 97
HTML Report for LHCI Scan Report Link

@ttpss930141011
Copy link
Contributor

Hello @JohnsonMao

這個 PR 中看到你在 next-i18next.config.js 中加入了 localePath,就修正了這個問題。
我蠻好奇是怎麼 detect 到問題的,與是怎麼做測試的?
因為我們目前 Vercel Preview 在登入後都會導向 Production,無法有效發揮 preview 的功能讓我覺得有點困擾。

I will really appreciate if you share more details!

@JohnsonMao
Copy link
Contributor Author

很遺憾~目前我也只是依據線索猜測,所以沒辦法測試
我是參考 i18next issue
另外 Preview 目前看來只能從 environment variables 下手
實際要怎麼調整,目前沒甚麼想法

@ttpss930141011
Copy link
Contributor

很遺憾~目前我也只是依據線索猜測,所以沒辦法測試 我是參考 i18next issue 另外 Preview 目前看來只能從 environment variables 下手 實際要怎麼調整,目前沒甚麼想法

了解了!那來合併看看!

@ttpss930141011 ttpss930141011 merged commit 553edc4 into main Aug 30, 2023
@ttpss930141011 ttpss930141011 deleted the fix/i18n branch August 30, 2023 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix something in main sprint 9
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: i18n Not Working in Production
4 participants