Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fast join room #289

Merged
merged 1 commit into from
Aug 31, 2023
Merged

feat: fast join room #289

merged 1 commit into from
Aug 31, 2023

Conversation

ttpss930141011
Copy link
Contributor

Why need this change? / Root cause:

  • Implement fast join button

Changes made:

  • Add fast join button in FastJoinButton
  • Add new request fastJoinGameEndpoint
  • Change the response data of the getAllGamesEndpoint

Test Scope / Change impact:

Issue

@ttpss930141011 ttpss930141011 self-assigned this Aug 29, 2023
@ttpss930141011 ttpss930141011 linked an issue Aug 29, 2023 that may be closed by this pull request
@vercel
Copy link

vercel bot commented Aug 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
game-lobby-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 31, 2023 4:27am

Copy link
Contributor

@Yuwen-ctw Yuwen-ctw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@GaaSBot
Copy link

GaaSBot commented Aug 31, 2023

Knip Scan Result for d67cda9

Unused files (10)
Unused files (10)
.bundlewatch.config.js
components/shared/Chat/ChatContent.tsx
components/shared/Chat/ChatMessage.tsx
components/shared/Chat/index.tsx
components/shared/Icon/group/news.tsx
configs/i18nConfigs.ts
lighthouserc.js
reset.d.ts
scripts/knipScanReporter.js
scripts/lhciScanReporter.js
Unused dependencies (2)
Unused dependencies (2)
@svgr/webpack package.json
sharp package.json
Unused devDependencies (5)
Unused devDependencies (5)
@actions/github package.json
@octokit/core package.json
@storybook/blocks package.json
@storybook/testing-library package.json
@total-typescript/ts-reset package.json
Configuration issues (1)
Configuration issues (1)
Unused item in ignoreDependencies: @next/bundle-analyzer

@GaaSBot
Copy link

GaaSBot commented Aug 31, 2023

🤖 Lighthouse Scan Result for d67cda9

/rooms
Metric Value
Performance 67
Seo 80
Accessibility 79
HTML Report for LHCI Scan Report Link
/rooms/abc
Metric Value
Performance 75
Seo 80
Accessibility 69
HTML Report for LHCI Scan Report Link
/login
Metric Value
Performance 50
Seo 80
Accessibility 97
HTML Report for LHCI Scan Report Link

@ttpss930141011 ttpss930141011 merged commit 50ecc6a into main Aug 31, 2023
@ttpss930141011 ttpss930141011 deleted the feature/fast-join branch August 31, 2023 10:15
@ttpss930141011 ttpss930141011 restored the feature/fast-join branch August 31, 2023 14:25
This was referenced Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: 快速進入 -2
4 participants