Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #281-RoomListView render error #284

Merged
merged 1 commit into from
Aug 21, 2023
Merged

fix: #281-RoomListView render error #284

merged 1 commit into from
Aug 21, 2023

Conversation

Yuwen-ctw
Copy link
Contributor

@Yuwen-ctw Yuwen-ctw commented Aug 21, 2023

Why need this change? / Root cause:

  • The root cause of this problem stems from incorrespondence API formats.

Changes made:

  • Redefine the response type of Get/rooms according to Swagger
image

Test Scope / Change impact:

Issue

The root cause of this problem stems from incorrespondence API formats.
@Yuwen-ctw Yuwen-ctw added bug Fix something in main sprint 9 labels Aug 21, 2023
@Yuwen-ctw Yuwen-ctw self-assigned this Aug 21, 2023
@vercel
Copy link

vercel bot commented Aug 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
game-lobby-web ✅ Ready (Inspect) Visit Preview Aug 21, 2023 0:08am

@Yuwen-ctw Yuwen-ctw linked an issue Aug 21, 2023 that may be closed by this pull request
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@GaaSBot
Copy link

GaaSBot commented Aug 21, 2023

Knip Scan Result for 1bd1fef

Unused files (10)
Unused files (10)
.bundlewatch.config.js
components/shared/Chat/ChatContent.tsx
components/shared/Chat/ChatMessage.tsx
components/shared/Chat/index.tsx
components/shared/Icon/group/news.tsx
configs/i18nConfigs.ts
lighthouserc.js
reset.d.ts
scripts/knipScanReporter.js
scripts/lhciScanReporter.js
Unused dependencies (2)
Unused dependencies (2)
@svgr/webpack package.json
sharp package.json
Unused devDependencies (5)
Unused devDependencies (5)
@actions/github package.json
@octokit/core package.json
@storybook/blocks package.json
@storybook/testing-library package.json
@total-typescript/ts-reset package.json
Configuration issues (1)
Configuration issues (1)
Unused item in ignoreDependencies: @next/bundle-analyzer

@GaaSBot
Copy link

GaaSBot commented Aug 21, 2023

🤖 Lighthouse Scan Result for 1bd1fef

/rooms
Metric Value
Performance 63
Seo 80
Accessibility 79
HTML Report for LHCI Scan Report Link
/rooms/abc
Metric Value
Performance 76
Seo 80
Accessibility 69
HTML Report for LHCI Scan Report Link
/login
Metric Value
Performance 50
Seo 80
Accessibility 97
HTML Report for LHCI Scan Report Link

@ttpss930141011 ttpss930141011 merged commit 089add2 into main Aug 21, 2023
@ttpss930141011 ttpss930141011 deleted the fix/#281 branch August 21, 2023 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix something in main sprint 9
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: RoomListView render error
3 participants