Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: LHCI Failure #269

Merged
merged 1 commit into from
Aug 13, 2023
Merged

fix: LHCI Failure #269

merged 1 commit into from
Aug 13, 2023

Conversation

Yuwen-ctw
Copy link
Contributor

@Yuwen-ctw Yuwen-ctw commented Aug 13, 2023

Why need this change? / Root cause:

  • The CI pipeline is currently failing due to the absence of the mock Sokcet.IO server during CI mode.
    image

Changes made:

  • Modified the WebSocket server configuration logic to ensure the mock Sokcet.IO server is started not only in development mode but also in CI mode.

Test Scope / Change impact:

Issue

@Yuwen-ctw Yuwen-ctw added the bug Fix something in main label Aug 13, 2023
@Yuwen-ctw Yuwen-ctw self-assigned this Aug 13, 2023
@vercel
Copy link

vercel bot commented Aug 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
game-lobby-web ✅ Ready (Inspect) Visit Preview Aug 13, 2023 11:23am

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@GaaSBot
Copy link

GaaSBot commented Aug 13, 2023

Knip Scan Result for af68dbe

Unused files (10)
Unused files (10)
.bundlewatch.config.js
components/shared/Chat/ChatContent.tsx
components/shared/Chat/ChatMessage.tsx
components/shared/Chat/index.tsx
components/shared/Icon/group/news.tsx
configs/i18nConfigs.ts
lighthouserc.js
reset.d.ts
scripts/knipScanReporter.js
scripts/lhciScanReporter.js
Unused dependencies (2)
Unused dependencies (2)
@svgr/webpack package.json
sharp package.json
Unused devDependencies (5)
Unused devDependencies (5)
@actions/github package.json
@octokit/core package.json
@storybook/blocks package.json
@storybook/testing-library package.json
@total-typescript/ts-reset package.json
Configuration issues (1)
Configuration issues (1)
Unused item in ignoreDependencies: @next/bundle-analyzer

@GaaSBot
Copy link

GaaSBot commented Aug 13, 2023

🤖 Lighthouse Scan Result for af68dbe

/rooms
Metric Value
Performance 67
Seo 80
Accessibility 79
HTML Report for LHCI Scan Report Link
/rooms/abc
Metric Value
Performance 76
Seo 80
Accessibility 69
HTML Report for LHCI Scan Report Link
/login
Metric Value
Performance 50
Seo 80
Accessibility 97
HTML Report for LHCI Scan Report Link

@Yuwen-ctw Yuwen-ctw changed the title [WIP]fix: run mock socket server during CI mode fix: run mock socket server during CI mode Aug 13, 2023
@Yuwen-ctw Yuwen-ctw linked an issue Aug 13, 2023 that may be closed by this pull request
@Yuwen-ctw Yuwen-ctw changed the title fix: run mock socket server during CI mode fix: LHCI Failure Aug 13, 2023
@ttpss930141011 ttpss930141011 merged commit df168e2 into main Aug 13, 2023
@ttpss930141011 ttpss930141011 deleted the fix/LHCI branch August 13, 2023 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix something in main
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix: LHCI 失敗
3 participants