-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: storybook occurred an unexpected error when starting #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
41fb92b
to
68cb242
Compare
- Update `@storybook/addon-essentials` from version `7.0.23` to `7.2.3` - Update `@storybook/addon-interactions` from version `7.0.23` to `7.2.3` - Update `@storybook/addon-links` from version `7.0.23` to `7.2.3` - Update `@storybook/blocks` from version `7.0.23` to `7.2.3` - Update `@storybook/nextjs` from version `7.0.23` to `7.2.3` - Update `@storybook/react` from version `7.0.23` to `7.2.3` - Update `storybook` from version `7.0.23` to `7.2.3`
68cb242
to
02e2bb4
Compare
Kudos, SonarCloud Quality Gate passed!
|
✅ Knip Scan Result for 02e2bb4 Unused files (10)
Unused dependencies (2)
Unused devDependencies (5)
Configuration issues (1)
|
🤖 Lighthouse Scan Result for 02e2bb4 /rooms
/rooms/abc
/login
|
Yuwen-ctw
approved these changes
Aug 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why need this change
Root cause
Changes made
@storybook/addon-essentials
from version7.0.23
to7.2.3
@storybook/addon-interactions
from version7.0.23
to7.2.3
@storybook/addon-links
from version7.0.23
to7.2.3
@storybook/blocks
from version7.0.23
to7.2.3
@storybook/nextjs
from version7.0.23
to7.2.3
@storybook/react
from version7.0.23
to7.2.3
storybook
from version7.0.23
to7.2.3
Test Scope / Change impact
Issue
Note
前幾日 @bxbdev 找我討論在升級 yarn 3 後 Storybook 壞掉的問題,我想問題是出在 Next.js 版本更新導致 Storybook 無法使用,不是升級 yarn 的問題。
有趣的是,在修復了 Storybook 之後準備 commit 時在 Hasky 出現錯誤,錯誤訊息如此 issue,Storybook 的成員猜想這或許是 yarn 1 的問題,並且不知道原因。他提出了兩種解法:
但最後我只有將 node_modules 砍掉,重新 yarn 一次錯誤變消失了,這點還要後續追蹤看看會不會有其它問題。
更新:
在 CI install dependencies 時出了一樣的錯,之後在 package.json 依建議增加了 resolutions 後暫時解決了問題。
但隨著越來越多的 package 試圖通過提供混合esm/cjs 支持來逐步進入 esm 支持,也許在未來放棄 cjs 支持的 package 會越來越多,升級 yarn 或許是未來可以討論的選項之一。