Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: context lost after navigated #262

Merged
merged 1 commit into from
Aug 8, 2023
Merged

Conversation

Yuwen-ctw
Copy link
Contributor

@Yuwen-ctw Yuwen-ctw commented Aug 7, 2023

Why need this change? / Root cause:

  • Discussion
  • The context gets reset when switching between page components that do not use the serverSideTranslations function to load staticProps
  • Reference: i18next #1683

Changes made:

  • Apply serverSideTranslations function to every page component.
  • Fix some ESLint warning.

Test Scope / Change impact:

Issue

@Yuwen-ctw Yuwen-ctw added the bug Fix something in main label Aug 7, 2023
@Yuwen-ctw Yuwen-ctw self-assigned this Aug 7, 2023
@vercel
Copy link

vercel bot commented Aug 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
game-lobby-web ✅ Ready (Inspect) Visit Preview Aug 7, 2023 2:02pm

@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@GaaSBot
Copy link

GaaSBot commented Aug 7, 2023

Knip Scan Result for eb0f2ef

Unused files (10)
Unused files (10)
.bundlewatch.config.js
components/shared/Chat/ChatContent.tsx
components/shared/Chat/ChatMessage.tsx
components/shared/Chat/index.tsx
components/shared/Icon/group/news.tsx
configs/i18nConfigs.ts
lighthouserc.js
reset.d.ts
scripts/knipScanReporter.js
scripts/lhciScanReporter.js
Unused dependencies (2)
Unused dependencies (2)
@svgr/webpack package.json
sharp package.json
Unused devDependencies (5)
Unused devDependencies (5)
@actions/github package.json
@octokit/core package.json
@storybook/blocks package.json
@storybook/testing-library package.json
@total-typescript/ts-reset package.json
Configuration issues (1)
Configuration issues (1)
Unused item in ignoreDependencies: @next/bundle-analyzer

@ttpss930141011
Copy link
Contributor

超讚!現在切換時 socket 也不會因 context re-mount 導致斷開重連,近日會將 Discussions 內的問題做一個總結,感謝你的幫忙!

@ttpss930141011 ttpss930141011 merged commit 218ced9 into main Aug 8, 2023
@ttpss930141011 ttpss930141011 deleted the fix/context-reset branch August 8, 2023 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix something in main
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants