Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix(auth): tmp rm authentication #258

Merged
merged 1 commit into from
Jul 30, 2023
Merged

Conversation

Parkerhiphop
Copy link
Contributor

@Parkerhiphop Parkerhiphop commented Jul 30, 2023

Why need this change? / Root cause:

  • Because of the POST /authentication had been protected(require Bearer token), it cause error after login.
  • The authentication is POSTed every time we refresh, but we still haven't clarified the refresh workflow.
  • Put it back after we understand why authentication exists, when we need to request it, and how to handle the data after receiving the response.

Changes made:

  • temporarily remove the authentication POST request.

Test Scope / Change impact:

Issue

@Parkerhiphop Parkerhiphop self-assigned this Jul 30, 2023
@vercel
Copy link

vercel bot commented Jul 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
game-lobby-web ✅ Ready (Inspect) Visit Preview Jul 30, 2023 1:31am

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell D 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@Parkerhiphop Parkerhiphop changed the title 🐛 Fix(auth): tmp rm authentication 🐛 fix(auth): tmp rm authentication Jul 30, 2023
@github-actions github-actions bot added the bug Fix something in main label Jul 30, 2023
@GaaSBot
Copy link

GaaSBot commented Jul 30, 2023

Knip Scan Result for e7b54d0

Unused files (10)
Unused files (10)
.bundlewatch.config.js
components/shared/Chat/ChatContent.tsx
components/shared/Chat/ChatMessage.tsx
components/shared/Chat/index.tsx
components/shared/Icon/group/news.tsx
configs/i18nConfigs.ts
lighthouserc.js
reset.d.ts
scripts/knipScanReporter.js
scripts/lhciScanReporter.js
Unused dependencies (2)
Unused dependencies (2)
@svgr/webpack package.json
sharp package.json
Unused devDependencies (5)
Unused devDependencies (5)
@actions/github package.json
@octokit/core package.json
@storybook/blocks package.json
@storybook/testing-library package.json
@total-typescript/ts-reset package.json
Configuration issues (1)
Configuration issues (1)
Unused item in ignoreDependencies: @next/bundle-analyzer

@Parkerhiphop Parkerhiphop merged commit 465dc79 into main Jul 30, 2023
@Parkerhiphop Parkerhiphop deleted the hotfix/authentication branch July 30, 2023 01:33
@GaaSBot
Copy link

GaaSBot commented Jul 30, 2023

🤖 Lighthouse Scan Result for e7b54d0

/rooms
Metric Value
Performance 66
Seo 80
Accessibility 79
HTML Report for LHCI Scan Report Link
/rooms/abc
Metric Value
Performance 76
Seo 80
Accessibility 69
HTML Report for LHCI Scan Report Link
/login
Metric Value
Performance 51
Seo 80
Accessibility 97
HTML Report for LHCI Scan Report Link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix something in main
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants