Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: #237 remove anything temporarily useless #248

Merged
merged 1 commit into from
Jul 16, 2023
Merged

fix: #237 remove anything temporarily useless #248

merged 1 commit into from
Jul 16, 2023

Conversation

physicsSorcererKing
Copy link
Contributor

Why need this change? / Root cause:

  • remove anything temporarily useless layouts, functions

Changes made:

  • remove add/sub 10 pages buttons in rooms page
  • remove useless text and actions in Header
  • remove news in Sidebar

Test Scope / Change impact:

Issue

@physicsSorcererKing
fix: #237
2a60d7b 
1. remove add/sub 10 pages buttons in rooms page
2. remove useless text and actions in Header
3. remove news in Sidebar
@physicsSorcererKing physicsSorcererKing linked an issue Jul 16, 2023 that may be closed by this pull request
Fix: 移除暫不開發的功能 - 2 #237
Closed
@github-actions github-actions bot added the bug Fix something in main label Jul 16, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@GaaSBot
Copy link

GaaSBot commented Jul 16, 2023

✅ Knip Scan Result for 2a60d7b

Unused files (9)
Unused files (9)
.bundlewatch.config.js
components/shared/Chat/ChatContent.tsx
components/shared/Chat/ChatMessage.tsx
components/shared/Chat/index.tsx
components/shared/Icon/group/news.tsx
lighthouserc.js
reset.d.ts
scripts/knipScanReporter.js
scripts/lhciScanReporter.js
Unused dependencies (2)
Unused dependencies (2)
@svgr/webpack package.json
sharp package.json
Unused devDependencies (5)
Unused devDependencies (5)
@actions/github package.json
@octokit/core package.json
@storybook/blocks package.json
@storybook/testing-library package.json
@total-typescript/ts-reset package.json
Configuration issues (1)
Configuration issues (1)
Unused item in ignoreDependencies: @next/bundle-analyzer

@physicsSorcererKing physicsSorcererKing changed the title fix: #237 fix: #237 remove anything temporarily useless Jul 16, 2023
@GaaSBot
Copy link

GaaSBot commented Jul 16, 2023

🤖 Lighthouse Scan Result for 2a60d7b

/rooms
Metric Value
Performance 71
Seo 80
Accessibility 76
HTML Report for LHCI Scan Report Link
/rooms/abc
Metric Value
Performance 77
Seo 80
Accessibility 65
HTML Report for LHCI Scan Report Link
/login
Metric Value
Performance 52
Seo 80
Accessibility 94
HTML Report for LHCI Scan Report Link

@Parkerhiphop Parkerhiphop merged commit 8ecfcd5 into main Jul 16, 2023
@Parkerhiphop Parkerhiphop deleted the feature/remove-temporarily-useless branch July 16, 2023 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Parkerhiphop Parkerhiphop Parkerhiphop approved these changes

Assignees
No one assigned
Labels
bug Fix something in main
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix: 移除暫不開發的功能 - 2
3 participants
@physicsSorcererKing @GaaSBot @Parkerhiphop