Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: start game #247

Merged
merged 1 commit into from
Aug 6, 2023
Merged

feat: start game #247

merged 1 commit into from
Aug 6, 2023

Conversation

bxbdev
Copy link
Contributor

@bxbdev bxbdev commented Jul 15, 2023

Why need this change? / Root cause:

  • Updated mock_roomInfo
  • Added handleStart function
  • Added startGame API

Changes made:

Test Scope / Change impact:

Issue

@github-actions github-actions bot added the feature New Feature label Jul 15, 2023
@bxbdev bxbdev requested a review from ttpss930141011 July 15, 2023 15:18
@bxbdev bxbdev self-assigned this Jul 15, 2023
@bxbdev bxbdev force-pushed the feature/start-game branch from a015fc0 to c170b67 Compare July 15, 2023 15:24
@bxbdev bxbdev force-pushed the feature/start-game branch from c170b67 to b64e637 Compare July 29, 2023 09:26
@vercel
Copy link

vercel bot commented Jul 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
game-lobby-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 29, 2023 9:26am

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@GaaSBot
Copy link

GaaSBot commented Jul 29, 2023

Knip Scan Result for b64e637

Unused files (10)
Unused files (10)
.bundlewatch.config.js
components/shared/Chat/ChatContent.tsx
components/shared/Chat/ChatMessage.tsx
components/shared/Chat/index.tsx
components/shared/Icon/group/news.tsx
configs/i18nConfigs.ts
lighthouserc.js
reset.d.ts
scripts/knipScanReporter.js
scripts/lhciScanReporter.js
Unused dependencies (2)
Unused dependencies (2)
@svgr/webpack package.json
sharp package.json
Unused devDependencies (5)
Unused devDependencies (5)
@actions/github package.json
@octokit/core package.json
@storybook/blocks package.json
@storybook/testing-library package.json
@total-typescript/ts-reset package.json
Configuration issues (1)
Configuration issues (1)
Unused item in ignoreDependencies: @next/bundle-analyzer

@GaaSBot
Copy link

GaaSBot commented Jul 29, 2023

🤖 Lighthouse Scan Result for b64e637

/rooms
Metric Value
Performance 60
Seo 80
Accessibility 79
HTML Report for LHCI Scan Report Link
/rooms/abc
Metric Value
Performance 75
Seo 80
Accessibility 69
HTML Report for LHCI Scan Report Link
/login
Metric Value
Performance 50
Seo 80
Accessibility 97
HTML Report for LHCI Scan Report Link

@Yuwen-ctw Yuwen-ctw merged commit 36f89fa into main Aug 6, 2023
@Yuwen-ctw Yuwen-ctw deleted the feature/start-game branch August 6, 2023 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: 房主按下開始遊戲 - 2
4 participants