Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sidebar links #232

Merged
merged 1 commit into from
Jul 9, 2023
Merged

fix: sidebar links #232

merged 1 commit into from
Jul 9, 2023

Conversation

pcshen0828
Copy link
Contributor

@pcshen0828 pcshen0828 commented Jul 8, 2023

Why need this change? / Root cause:

  • Fix Sidebar links to enable navigation

Changes made:

  • Embed links in the Sidebar component

Test Scope / Change impact:

Issue

@github-actions github-actions bot added the bug Fix something in main label Jul 8, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@pcshen0828 pcshen0828 self-assigned this Jul 8, 2023
@GaaSBot
Copy link

GaaSBot commented Jul 8, 2023

Knip Scan Result for 71e319f

Unused files (5)
Unused files (5)
.bundlewatch.config.js
lighthouserc.js
reset.d.ts
scripts/knipScanReporter.js
scripts/lhciScanReporter.js
Unused dependencies (2)
Unused dependencies (2)
@svgr/webpack package.json
sharp package.json
Unused devDependencies (5)
Unused devDependencies (5)
@actions/github package.json
@octokit/core package.json
@storybook/blocks package.json
@storybook/testing-library package.json
@total-typescript/ts-reset package.json
Configuration issues (1)
Configuration issues (1)
Unused item in ignoreDependencies: @next/bundle-analyzer

@pcshen0828 pcshen0828 linked an issue Jul 8, 2023 that may be closed by this pull request
@GaaSBot
Copy link

GaaSBot commented Jul 8, 2023

🤖 Lighthouse Scan Result for 71e319f

/rooms
Metric Value
Performance 67
Seo 80
Accessibility 79
HTML Report for LHCI Scan Report Link
/rooms/abc
Metric Value
Performance 76
Seo 80
Accessibility 67
HTML Report for LHCI Scan Report Link
/login
Metric Value
Performance 52
Seo 80
Accessibility 94
HTML Report for LHCI Scan Report Link

@Parkerhiphop Parkerhiphop merged commit 7a3d1f9 into main Jul 9, 2023
@Parkerhiphop Parkerhiphop deleted the fix/sidebar-link branch July 9, 2023 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix something in main sprint 4 sprint 5
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix: Sidebar 的 link 要有作用 - 1
3 participants