Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix/private selected #231

Merged
merged 2 commits into from
Jul 19, 2023
Merged

fix/private selected #231

merged 2 commits into from
Jul 19, 2023

Conversation

arealclimber
Copy link
Contributor

Why need this change? / Root cause:

  • Clicking the password when creating a room should select the private room immediately

Changes made:

component:

  • PasswordField
  • CreateRoomModal

Test Scope / Change impact:

Issue

@arealclimber arealclimber self-assigned this Jul 7, 2023
@arealclimber arealclimber linked an issue Jul 7, 2023 that may be closed by this pull request
Fix: 開設房間 輸入房間密碼時 直接選過去 -1 #230
Closed
@arealclimber arealclimber added the bug Fix something in main label Jul 7, 2023
@arealclimber arealclimber changed the title Fix/private selected fix/private selected Jul 9, 2023
JohnsonMao
JohnsonMao requested changes Jul 13, 2023
View reviewed changes
Copy link
Contributor

@JohnsonMao JohnsonMao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

改完應該就 OK 了~

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@GaaSBot
Copy link

GaaSBot commented Jul 17, 2023

✅ Knip Scan Result for ae944b5

Unused files (9)
Unused files (9)
.bundlewatch.config.js
components/shared/Chat/ChatContent.tsx
components/shared/Chat/ChatMessage.tsx
components/shared/Chat/index.tsx
components/shared/Icon/group/news.tsx
lighthouserc.js
reset.d.ts
scripts/knipScanReporter.js
scripts/lhciScanReporter.js
Unused dependencies (2)
Unused dependencies (2)
@svgr/webpack package.json
sharp package.json
Unused devDependencies (5)
Unused devDependencies (5)
@actions/github package.json
@octokit/core package.json
@storybook/blocks package.json
@storybook/testing-library package.json
@total-typescript/ts-reset package.json
Configuration issues (1)
Configuration issues (1)
Unused item in ignoreDependencies: @next/bundle-analyzer

@GaaSBot
Copy link

GaaSBot commented Jul 17, 2023

🤖 Lighthouse Scan Result for ae944b5

/rooms
Metric Value
Performance 72
Seo 80
Accessibility 76
HTML Report for LHCI Scan Report Link
/rooms/abc
Metric Value
Performance 77
Seo 80
Accessibility 65
HTML Report for LHCI Scan Report Link
/login
Metric Value
Performance 51
Seo 80
Accessibility 94
HTML Report for LHCI Scan Report Link

@Parkerhiphop Parkerhiphop merged commit 516894d into main Jul 19, 2023
@Parkerhiphop Parkerhiphop deleted the fix/private-selected branch July 19, 2023 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnsonMao JohnsonMao JohnsonMao approved these changes

@Yuwen-ctw Yuwen-ctw Yuwen-ctw approved these changes

@ttpss930141011 ttpss930141011 Awaiting requested review from ttpss930141011

@bxbdev bxbdev Awaiting requested review from bxbdev

@Parkerhiphop Parkerhiphop Awaiting requested review from Parkerhiphop

@HongLinLiao HongLinLiao Awaiting requested review from HongLinLiao

@pcshen0828 pcshen0828 Awaiting requested review from pcshen0828

@dandedotdev dandedotdev Awaiting requested review from dandedotdev

Assignees

@arealclimber arealclimber

Labels
bug Fix something in main reviewing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix: 開設房間 輸入房間密碼時 直接選過去 -1
5 participants
@arealclimber @GaaSBot @JohnsonMao @Yuwen-ctw @Parkerhiphop