Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove duplicate exports, unused Modal and props-type #210

Merged
merged 2 commits into from
Jul 6, 2023
Merged

refactor: remove duplicate exports, unused Modal and props-type #210

merged 2 commits into from
Jul 6, 2023

Conversation

Yuwen-ctw
Copy link
Contributor

Why need this change? / Root cause:

  • Remove duplicate exports, unused Modal and props-type

Changes made:

Test Scope / Change impact:

Issue

@Yuwen-ctw Yuwen-ctw added the refactor refactor the changes already merged. label Jun 26, 2023
@Yuwen-ctw Yuwen-ctw force-pushed the refactor/resolve-unused-from-knip-scan branch 8 times, most recently from ef98092 to 931e7a2 Compare July 3, 2023 12:23
@Yuwen-ctw Yuwen-ctw force-pushed the refactor/resolve-unused-from-knip-scan branch from 931e7a2 to aef2e37 Compare July 3, 2023 13:59
@Yuwen-ctw Yuwen-ctw self-assigned this Jul 3, 2023
@Yuwen-ctw Yuwen-ctw linked an issue Jul 3, 2023 that may be closed by this pull request
Refactor: resolve unused from knip scan #196
Closed
@Yuwen-ctw Yuwen-ctw requested a review from Parkerhiphop July 3, 2023 15:16
@Yuwen-ctw Yuwen-ctw changed the title [WIP]refactor: remove duplicate exports, unused Modal and props-type refactor: remove duplicate exports, unused Modal and props-type Jul 3, 2023
@Yuwen-ctw Yuwen-ctw force-pushed the refactor/resolve-unused-from-knip-scan branch from aef2e37 to 21005da Compare July 3, 2023 22:42
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@GaaSBot
Copy link

GaaSBot commented Jul 6, 2023

✅ Knip Scan Result for 41f1231

Unused files (5)
Unused files (5)
.bundlewatch.config.js
lighthouserc.js
reset.d.ts
scripts/knipScanReporter.js
scripts/lhciScanReporter.js
Unused dependencies (2)
Unused dependencies (2)
@svgr/webpack package.json
sharp package.json
Unused devDependencies (5)
Unused devDependencies (5)
@actions/github package.json
@octokit/core package.json
@storybook/blocks package.json
@storybook/testing-library package.json
@total-typescript/ts-reset package.json
Configuration issues (1)
Configuration issues (1)
Unused item in ignoreDependencies: @next/bundle-analyzer

@GaaSBot
Copy link

GaaSBot commented Jul 6, 2023

🤖 Lighthouse Scan Result for 41f1231

/rooms
Metric Value
Performance 65
Seo 80
Accessibility 78
HTML Report for LHCI Scan Report Link
/rooms/abc
Metric Value
Performance 77
Seo 80
Accessibility 67
HTML Report for LHCI Scan Report Link
/login
Metric Value
Performance 52
Seo 80
Accessibility 94
HTML Report for LHCI Scan Report Link

@Parkerhiphop Parkerhiphop merged commit 0ed3a7a into main Jul 6, 2023
@Parkerhiphop Parkerhiphop deleted the refactor/resolve-unused-from-knip-scan branch July 6, 2023 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Parkerhiphop Parkerhiphop Parkerhiphop approved these changes

Assignees

@Yuwen-ctw Yuwen-ctw

Labels
refactor refactor the changes already merged. sprint 5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor: resolve unused from knip scan
3 participants
@Yuwen-ctw @GaaSBot @Parkerhiphop