Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: userinfo with editing #126

Merged
merged 2 commits into from
Jun 5, 2023
Merged

feat: userinfo with editing #126

merged 2 commits into from
Jun 5, 2023
+167 −79

Conversation

ttpss930141011
Copy link
Contributor

@ttpss930141011 ttpss930141011 commented Jun 2, 2023 •
edited
Loading

Why need this change? / Root cause:

Changes made:

  • Added IO delay in pages\api\mock\users\me.ts.
  • Added editing function in components\lobby\UserInfoModal.tsx.

Test Scope / Change impact:

Issue

@ttpss930141011 ttpss930141011 self-assigned this Jun 2, 2023
@ttpss930141011 ttpss930141011 linked an issue Jun 2, 2023 that may be closed by this pull request
更新使用者資訊 Modal 的 ＵＩ - 3 #104
Closed
@ttpss930141011 ttpss930141011 changed the title feat: userinfo with editing [WIP]feat: userinfo with editing Jun 2, 2023
@ttpss930141011
Copy link
Contributor Author

ttpss930141011 commented Jun 2, 2023 •
edited
Loading

@bxbdev 這邊小魔改了一下你的 UserInfoModal，有任何建議請和我說。

@bxbdev
Copy link
Contributor

bxbdev commented Jun 2, 2023 •
edited
Loading

寫得有點沒自信，想請問大家有沒有甚麼意見關於我的程式碼有哪邊可以改得更好。 @bxbdev 這邊小魔改了一下你的 UserInfoModal，有任何建議請和我說。

@ttpss930141011 看過沒有什麼問題，有大佬處理很安心 XDDDD
補充一點，如果再補一個中文的長度驗證進去，會不會比較好？ 畢竟中文跟英文長度計算不一樣哦！

@ttpss930141011 ttpss930141011 force-pushed the feature/userinfo-with-editing branch from 24b91f3 to 21d70ce Compare June 3, 2023 08:12
JohnsonMao
JohnsonMao requested changes Jun 4, 2023
View reviewed changes
Copy link
Contributor

@JohnsonMao JohnsonMao left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

辛苦了~再麻煩修改

@ttpss930141011 ttpss930141011 force-pushed the feature/userinfo-with-editing branch from 21d70ce to 8c18c4e Compare June 4, 2023 11:58
@ttpss930141011 ttpss930141011 requested a review from JohnsonMao June 4, 2023 12:01
@ttpss930141011 ttpss930141011 force-pushed the feature/userinfo-with-editing branch from 8c18c4e to 2b7b5ae Compare June 4, 2023 12:06
@ttpss930141011 ttpss930141011 force-pushed the feature/userinfo-with-editing branch from 2b7b5ae to f7838a1 Compare June 4, 2023 12:43
@ttpss930141011 ttpss930141011 changed the title [WIP]feat: userinfo with editing feat: userinfo with editing Jun 4, 2023
@ttpss930141011 ttpss930141011 merged commit 1d4bb67 into main Jun 5, 2023
@ttpss930141011 ttpss930141011 deleted the feature/userinfo-with-editing branch June 5, 2023 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Parkerhiphop Parkerhiphop

@JohnsonMao JohnsonMao

@HongLinLiao HongLinLiao

@bxbdev bxbdev

@dandedotdev dandedotdev

Assignees

@ttpss930141011 ttpss930141011

Labels
feature New Feature sprint 3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

更新使用者資訊 Modal 的 ＵＩ - 3
4 participants
@ttpss930141011 @bxbdev @Parkerhiphop @JohnsonMao