Skip to content

Make diagnostic system aware of un-compiled modules#270

Merged
MarkusPrim merged 3 commits intomasterfrom
Issue61_a
Feb 17, 2021
Merged

Make diagnostic system aware of un-compiled modules#270
MarkusPrim merged 3 commits intomasterfrom
Issue61_a

Conversation

@MarkusPrim
Copy link
Collaborator

Currently the module diagnostic system is only aware of modules which are compiled. To make it aware of un-compiled modules this PR introduces a two-step procedure:

  • Run a small python script to crawl all gambit bits from the source directory at the end of cmake (or any other time).
  • Utilize the generated file to create a full list of gambit modules when using the diagnostic system, tagging them with ok or ditched/disabled.

This is the first of two PR related to Issue #61 . I thought it be best to create two simple PRs and discuss early. This PR alone also works perfectly fine standalone. The second PR will then tackle the issue of how the module/backend was removed from compilation, either if automatically disabled, or explicitly ditched.

Markus Prim added 2 commits February 14, 2021 13:55
…. This file can be used by the diagnostic system to give information about ditched modules. After running cmake, Gambit is not aware of ditched/disabled models and has to rely on this external information.
@MarkusPrim MarkusPrim added enhancement Core Core group task labels Feb 14, 2021
@MarkusPrim MarkusPrim requested a review from tegonzalo February 14, 2021 13:54
@MarkusPrim MarkusPrim self-assigned this Feb 14, 2021
Copy link
Collaborator

@tegonzalo tegonzalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not much to comment here, but just a general comment. You said that the second part of the PR would resolve when a module has been ditched or disabled. I'm not sure what you mean about disabled here, as modules are always part of the compilation unless they are ditched. If I am correct then you should just change line 63 of diagnostics.cpp to say ditched and that will be all.

@MarkusPrim
Copy link
Collaborator Author

Good point, I will change that. However the same does not apply for backends for example, and on that the comment about ditched/disabled was based.

@MarkusPrim
Copy link
Collaborator Author

@tegonzalo I incorporated your comments and will merge after the successful build.

@MarkusPrim MarkusPrim merged commit 8d1ae87 into master Feb 17, 2021
@MarkusPrim MarkusPrim deleted the Issue61_a branch February 17, 2021 14:36
@pstoecker
Copy link
Member

I have just tested ./gambit modules on CosmoBit_development which is up-to date with master and includes the modifications of this PR.

I have seen that ScannerBit is listed as ditched even though it is clearly there -- otherwise good look with scanning 😄 . I am not sure whether it only occurs to me, but this seems to be a small bug or easter egg.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Core Core group task enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants