Make diagnostic system aware of un-compiled modules#270
Conversation
…. This file can be used by the diagnostic system to give information about ditched modules. After running cmake, Gambit is not aware of ditched/disabled models and has to rely on this external information.
tegonzalo
left a comment
There was a problem hiding this comment.
Not much to comment here, but just a general comment. You said that the second part of the PR would resolve when a module has been ditched or disabled. I'm not sure what you mean about disabled here, as modules are always part of the compilation unless they are ditched. If I am correct then you should just change line 63 of diagnostics.cpp to say ditched and that will be all.
|
Good point, I will change that. However the same does not apply for backends for example, and on that the comment about ditched/disabled was based. |
…y will never be disabled).
|
@tegonzalo I incorporated your comments and will merge after the successful build. |
|
I have just tested I have seen that |
Currently the module diagnostic system is only aware of modules which are compiled. To make it aware of un-compiled modules this PR introduces a two-step procedure:
This is the first of two PR related to Issue #61 . I thought it be best to create two simple PRs and discuss early. This PR alone also works perfectly fine standalone. The second PR will then tackle the issue of how the module/backend was removed from compilation, either if automatically disabled, or explicitly ditched.