Grocery store orders page hw #10
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wrote make login manager
login/logout system works perfect, relations added to models
populate orders
dimigor
requested changes
Jun 10, 2020
| USERS_DIR = os.path.join(FIXTURES_DIR, "users.csv") | ||
| GOODS_DIR = os.path.join(FIXTURES_DIR, "goods.csv") | ||
| STORES_DIR = os.path.join(FIXTURES_DIR, "stores.csv") | ||
| USERS_FILENAME = os.path.join(FIXTURES_DIR, "users.csv") |
Collaborator
There was a problem hiding this comment.
it is actually PATH, not FILENAME
|
|
||
| def get_goods(): | ||
| with open(GOODS_DIR, "r") as f: | ||
| with open(GOODS_FILENAME, "r") as f: |
Collaborator
There was a problem hiding this comment.
it would be great if you handled all the possible exceptions
|
|
||
| class PopulateOrders(Command): | ||
| def run(self): | ||
| from grocery_store import app, db |
Collaborator
There was a problem hiding this comment.
do not make local imports
| "order_price": sum([good.good.price for good in order.order_lines]), | ||
| "order_goods": {good.good.name: good.good.price for good in order.order_lines} | ||
| } | ||
| orders_list.append(order_data) |
Collaborator
There was a problem hiding this comment.
you can use here list comprehensions
and would be great if you use NamedTuple instead of dict (It is a great opportunity to get familiar with)
| Sign Up | ||
| </a> | ||
| {% endif %} | ||
| {% if current_user.is_authenticated %} |
Collaborator
There was a problem hiding this comment.
too many checks if the user is authenticated
Try to check it one time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.