#3: Associate variable to CLI flag #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR introduces a new feature for conditional variable loading based on CLI flag presence (useWithFlag) and renames the existing flag property to useFlagInstead for better semantic clarity. The PR also includes CI improvements and documentation updates.
Key changes:
- Renamed
flagproperty touseFlagInsteadto better indicate its purpose (using a CLI flag instead of an environment variable) - Added new
useWithFlagproperty to conditionally load variables only when specific CLI flags are present - Added comprehensive test coverage for the new conditional loading feature
Reviewed changes
Copilot reviewed 5 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/index.ts | Renamed flag to useFlagInstead, added useWithFlag conditional loading logic, updated error messages |
| tests/index.test.ts | Updated tests to use useFlagInstead, added 6 new comprehensive test cases for useWithFlag functionality |
| README.md | Added CI badge and Node.js version badge, updated changelog for version 0.2.0 |
| SECURITY.md | Updated contact email address, removed commented-out code |
| .github/workflows/test-node.yml | New CI workflow to test across Node.js versions 20, 22, 24, and 25 |
| .github/workflows/main.yml | Reformatted indentation from spaces to consistent 4-space indentation |
| package-lock.json | Auto-generated npm changes adding "peer": true to various dependencies |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.