Run subshells in a nested scope #2752
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(That is, they should be a scope nested inside the scope/context where they're called, and not run in that scope directly.) Add a couple more tests. Document in Value.hs why builtins don't get an environment closed in with them. Closes #2751.
Switch test2242_2243 to use test-and-diff.sh. While working on the previous changes I became concerned about whether failures would actually be detected; the answer proves to be no. Errors that occur in a nested interactive subshell get trapped and discarded (because that's what the REPL does with errors) and at least present01 and present03 do not fail overall if the actions in the nested subshell, which are the point of those tests, fail. This requires adding some mangy stuff to the output postprocessing so that the timestamps in the output actually go away; however, we can get rid of all that once we fix #2090.
sauclovian-g
force-pushed
the
2751-subshell-scoping
branch
from
748e235 to
be8d396
Compare
|
force-push: operator error. Ignore the previous version |
RyanGlScott
approved these changes
Oct 28, 2025
sauclovian-g
added a commit
that referenced
this pull request
Oct 30, 2025
Should have been part of #2752. (Oops.)
sauclovian-g
added a commit
that referenced
this pull request
Oct 31, 2025
Should have been part of #2752. (Oops.)
sauclovian-g
added a commit
that referenced
this pull request
Oct 31, 2025
Should have been part of #2752. (Oops.)
sauclovian-g
added a commit
that referenced
this pull request
Nov 3, 2025
Should have been part of #2752. (Oops.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2751.