Remove ExtCns datatype #2732
Merged
Remove ExtCns datatype #2732
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Functions scFreshEC, scAbstractExts, and scGeneralizeExts are now gone.
RyanGlScott
approved these changes
Oct 22, 2025
|
|
||
| asJavaExpr :: Term -> Maybe String | ||
| asJavaExpr (asVariable -> Just ec) = Just (Text.unpack (ecShortName ec)) -- TODO? | ||
| asJavaExpr (asVariable -> Just (x, _)) = Just (Text.unpack (vnName x)) -- TODO? |
There was a problem hiding this comment.
I would love to know what this "TODO?" is supposed to refer to :)
There was a problem hiding this comment.
I have no idea; I don't suppose anyone else does either. I'll just remove it.
brianhuffman
added a commit
that referenced
this pull request
Oct 26, 2025
The "Ext" suffix formerly referred to type "ExtCns" which has been removed (#2732).
brianhuffman
added a commit
that referenced
this pull request
Oct 27, 2025
The "Ext" suffix formerly referred to type "ExtCns" which has been removed (#2732).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old type
ExtCns(along with its weirdEqinstance) is now removed in favor ofVarNameor(VarName, Term).Fixes #2332.