Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove leftover bashism in build.sh #2102

Merged
merged 1 commit into from
Aug 23, 2024
Merged

Remove leftover bashism in build.sh #2102

merged 1 commit into from
Aug 23, 2024

Conversation

sauclovian-g
Copy link
Contributor

Fixes #2100.

@sauclovian-g sauclovian-g added type: bug Issues reporting bugs or unexpected/unwanted behavior tooling: build system Issues involving SAW's build system labels Aug 23, 2024
RyanGlScott
RyanGlScott approved these changes Aug 23, 2024
View reviewed changes
Copy link
Contributor

@RyanGlScott RyanGlScott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can run the script after applying this change. Thanks!

@sauclovian-g sauclovian-g merged commit 4ea7d99 into master Aug 23, 2024
34 checks passed
@sauclovian-g sauclovian-g deleted the 2100-bashisms branch August 23, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RyanGlScott RyanGlScott RyanGlScott approved these changes

Assignees
No one assigned
Labels
tooling: build system Issues involving SAW's build system type: bug Issues reporting bugs or unexpected/unwanted behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

build.sh script fails with dash (Syntax error: "(" unexpected)
2 participants
@sauclovian-g @RyanGlScott