Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make rewriteSharedTerm ensure that rule instantiations are well-typed. #1351

Closed
wants to merge 1 commit into from
Closed

Make rewriteSharedTerm ensure that rule instantiations are well-typed. #1351

wants to merge 1 commit into from

Conversation

brianhuffman
Copy link
Contributor

Fixes #1312.

@brianhuffman
Copy link
Contributor Author

It looks like the awslc and blst proofs are now timing out in CI. Perhaps these proof scripts were actually relying on the buggy rewriter behavior of #1312.

@brianhuffman brianhuffman marked this pull request as draft June 24, 2021 13:51
@brianhuffman brianhuffman mentioned this pull request Jun 25, 2021
Open
@robdockins
Copy link
Contributor

I wonder if #1383 could be playing a role here.

@brianhuffman
Copy link
Contributor Author

This PR will require some major reworking before it's ready (see discussion on thread for #1312). Closing for now.

@RyanGlScott RyanGlScott deleted the rewriter-types branch March 22, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rewriter ignores types, creates incorrect term that fails check_goal
2 participants
@brianhuffman @robdockins