Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openssl_aes example proof hangs #1812

Open
bboston7 opened this issue Feb 4, 2023 · 4 comments
Open

openssl_aes example proof hangs #1812

bboston7 opened this issue Feb 4, 2023 · 4 comments
Labels
performance Issues that involve or include performance problems regression Something that used to work, but now doesn't tooling: CI Issues involving CI/CD scripts or processes type: bug Issues reporting bugs or unexpected/unwanted behavior
Milestone

Comments

@bboston7
Copy link
Contributor

bboston7 commented Feb 4, 2023

The proof in examples/openssl_aes appears to have bit-rotted. I tried running it on Ubuntu 22.04 with the latest what4-solvers solvers, and I used clang-12 to build the bitcode. The proof ran for a few hours before the kernel killed ABC on a machine with 24GB of RAM. SAW-0.9 has the same problem, so this doesn't appear to be a new issue. I'm not sure when the proof broke, or what caused the breakage (off the top of my head, it could be SAW changes, Clang changes, or ABC changes). I also tried changing the proof to use Z3 instead, but it still hung for a few hours before I called it "unlikely to terminate" and killed SAW.

To reproduce the problem, run make in examples/openssl_aes. This will build the bitcode and run the SAW proof.

@sauclovian-g sauclovian-g added type: bug Issues reporting bugs or unexpected/unwanted behavior performance Issues that involve or include performance problems tooling: CI Issues involving CI/CD scripts or processes regression Something that used to work, but now doesn't labels Nov 5, 2024
@sauclovian-g sauclovian-g added this to the Someday milestone Nov 5, 2024
@sauclovian-g
Copy link
Contributor

The examples should be getting built in the CI runs...

@RyanGlScott
Copy link
Contributor

There is a test_examples test case that runs some of the examples under the top-level examples directory, but it is set up to only run a subset of the examples. Currrently, this does not include openssl_aes. I agree that it would be nice to test this example in the CI as well (provided that it can be done in a reasonable amount of time).

@mccleeary-galois
Copy link
Contributor

There is a test_examples test case that runs some of the examples under the top-level examples directory, but it is set up to only run a subset of the examples. Currrently, this does not include openssl_aes. I agree that it would be nice to test this example in the CI as well (provided that it can be done in a reasonable amount of time).

If it doesn't run in a reasonable amount of time I still am an advocate of having a longer running CI for testing pre-release branches and the like.

@sauclovian-g
Copy link
Contributor

That and/or we should make sure everything gets run at least once every six months or something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Issues that involve or include performance problems regression Something that used to work, but now doesn't tooling: CI Issues involving CI/CD scripts or processes type: bug Issues reporting bugs or unexpected/unwanted behavior
Projects
None yet
Development

No branches or pull requests

4 participants