Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make mkModuleName use Text instead of String #1260

Closed
brianhuffman opened this issue Feb 23, 2021 · 0 comments · Fixed by #1270
Closed

Make mkModuleName use Text instead of String #1260

brianhuffman opened this issue Feb 23, 2021 · 0 comments · Fixed by #1270
Labels
tech debt Issues that document or involve technical debt

Comments

@brianhuffman
Copy link
Contributor

GaloisInc/saw-core#160 converts many of the remaining internal uses of the String type to Text, but there are still some uses of String in the external-facing saw-core API. One example is mkModuleName, which converts a list of Strings to a ModuleName. This should be converted to Text, which should let us avoid some addition uses of Text.unpack and Text.pack that still remain after GaloisInc/saw-core#160.
@brianhuffman brianhuffman transferred this issue from GaloisInc/saw-core Apr 27, 2021
@brianhuffman brianhuffman added the tech debt Issues that document or involve technical debt label Apr 27, 2021
@RyanGlScott RyanGlScott mentioned this issue Apr 27, 2021
Closed
brianhuffman pushed a commit that referenced this issue Apr 27, 2021
Make mkModuleName use Text instead of String.
06e6991 
Fixes #1260.
@brianhuffman brianhuffman mentioned this issue Apr 27, 2021
Merged
sauclovian-g added a commit that referenced this issue Oct 21, 2024
@sauclovian-g
Bump crucible and what4 to merge crucible #1260.
92f29e1 
This is a cleanup change that breaks the API (though in a minor way)
so we want to keep up with it. Apply the one-line fix to adjust to
that change.

Update what4 as well because crucible requires it.
sauclovian-g added a commit that referenced this issue Oct 21, 2024
@sauclovian-g
Merge pull request #2133 from GaloisInc/bump-crucible
0e1bba2 
Bump crucible and what4 to sync crucible #1260
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tech debt Issues that document or involve technical debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Convert some uses of String to Text GaloisInc/saw-script
1 participant
@brianhuffman