Add github action #44
Conversation
joehendrix
force-pushed
the
jhx/github
branch
29 times, most recently
from
84ef627 to
9ffcd05
Compare
joehendrix
force-pushed
the
jhx/github
branch
3 times, most recently
from
a0f1756 to
eaee65d
Compare
.github/workflows/ci.yaml
Outdated
| - name: Get CVC4 | ||
| run: | | ||
| git clone -b eqrange-quant --single-branch https://github.com/GaloisInc/vadd-CVC4.git . |
There was a problem hiding this comment.
Seems like this could be replaced with actions/checkout@v2 which would be the cannonical way to do it.
There was a problem hiding this comment.
Are you sure? This is a different repo than the main one.
There was a problem hiding this comment.
It looks like I can.
There was a problem hiding this comment.
I'll consider changing this, but what does it buy me?
There was a problem hiding this comment.
Sorry for the late reply, I didn't get a notification somehow.
Using the actions is preferred whenever possible because keeping with the conventional way to do something reduces cognitive overhead should someone else want to look at the code and contribute. Actions also strive to be cross platform while arbitrary shell commands don't.
I'm not particularly worried about it. But decreasing technical complexity by using established conventions has a tangible benefit for pipelines, especially if you ever want to test on windows as well.
There was a problem hiding this comment.
I disagree that there is a consensus, but I've changed to accommodate.
.github/workflows/ci.yaml
Outdated
| uses: actions/cache@v1 | ||
| with: | ||
| path: home/.cabal/store/ghc-${{ matrix.ghc-ver }} | ||
| key: ${{ matrix.name }}-build-${{ github.sha }} |
There was a problem hiding this comment.
This key will only ever match if you retry a failed build. I'd suggest just using something like ${{ runner.os}}-${{ matrix.ghc }}-cabal-store.
If you want to get fancy with it, you could have the primary key be the hash of the cabal.project.freeze file and then the fallback would be the "generic" cabal-store key.
eg:
key: ${{ matrix.name }}-build-${{ hashFiles('**/cabal.project.freeze') }}
restore-keys: ${{ runner.os}}-${{ matrix.ghc }}-cabal-storeThere was a problem hiding this comment.
runner.os should always be the same right?
There was a problem hiding this comment.
In your case, yes. If you decide to test on windows or another OS for some reason, then it won't be. Might be unnecessary future-proofing, but it depends. It's very necessary for Cryptol, but not every project shares Cryptol's concerns.
joehendrix
changed the title
joehendrix
changed the title
joehendrix
changed the title
joehendrix
force-pushed
the
jhx/github
branch
10 times, most recently
from
50676a1 to
71f2aa3
Compare
|
It's not in a place that it could be reviewed -- I'll push on Sunday. |
No description provided.